-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shadhankkk] iP #649
Open
shadhankkk
wants to merge
42
commits into
nus-cs2103-AY2425S1:master
Choose a base branch
from
shadhankkk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[shadhankkk] iP #649
Commits on Jul 11, 2024
-
damithc authored and damithc committed
Jul 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 68c58c1 - Browse repository at this point
Copy the full SHA 68c58c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03523ec - Browse repository at this point
Copy the full SHA 03523ecView commit details
Commits on Jul 21, 2024
-
build.gradle: Prevent generating a second JAR file
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Configuration menu - View commit details
-
Copy full SHA for 81a9c53 - Browse repository at this point
Copy the full SHA 81a9c53View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d139056 - Browse repository at this point
Copy the full SHA d139056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d11112 - Browse repository at this point
Copy the full SHA 6d11112View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac03ccb - Browse repository at this point
Copy the full SHA ac03ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 710f9d1 - Browse repository at this point
Copy the full SHA 710f9d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9890f84 - Browse repository at this point
Copy the full SHA 9890f84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 200b0b0 - Browse repository at this point
Copy the full SHA 200b0b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d91d2c1 - Browse repository at this point
Copy the full SHA d91d2c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5868cb4 - Browse repository at this point
Copy the full SHA 5868cb4View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c96b7f2 - Browse repository at this point
Copy the full SHA c96b7f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15726f4 - Browse repository at this point
Copy the full SHA 15726f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ccac9 - Browse repository at this point
Copy the full SHA c6ccac9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11b3bbe - Browse repository at this point
Copy the full SHA 11b3bbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea11576 - Browse repository at this point
Copy the full SHA ea11576View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0323b3c - Browse repository at this point
Copy the full SHA 0323b3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2de53 - Browse repository at this point
Copy the full SHA 1b2de53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35f7cab - Browse repository at this point
Copy the full SHA 35f7cabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cff8ae - Browse repository at this point
Copy the full SHA 8cff8aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e15d486 - Browse repository at this point
Copy the full SHA e15d486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4356792 - Browse repository at this point
Copy the full SHA 4356792View commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77314b5 - Browse repository at this point
Copy the full SHA 77314b5View commit details
Commits on Sep 20, 2024
-
Add assert statements to improve code safety
Some parts of the code assume certain conditions hold, but these assumptions are not explicitly enforced. This could lead to errors or unexpected behavior during execution if those assumptions are violated. Without enforcing these conditions, the code may fail silently, which could make debugging more difficult and reduce code reliability. Let's add assert statements to verify critical conditions at runtime. This ensures that assumptions are checked and provides immediate feedback if they are violated. Using assert is appropriate here because it adds minimal overhead and is disabled in production, keeping performance unaffected.
Configuration menu - View commit details
-
Copy full SHA for 3e66054 - Browse repository at this point
Copy the full SHA 3e66054View commit details -
Remove dead code from the program
The program contains blocks of code that are no longer executed or necessary. These portions of the codebase add unnecessary complexity and make it harder to maintain and read the code. Dead code can confuse developers and lead to misunderstandings about the program's behavior. It's important to keep the codebase clean and focused only on what is required. Let's remove the dead code to simplify the codebase, reduce maintenance overhead, and improve overall readability. Removing dead code helps avoid future bugs and keeps the project lean.
Configuration menu - View commit details
-
Copy full SHA for 00444a8 - Browse repository at this point
Copy the full SHA 00444a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99206f5 - Browse repository at this point
Copy the full SHA 99206f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 650de1e - Browse repository at this point
Copy the full SHA 650de1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f11762f - Browse repository at this point
Copy the full SHA f11762fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4002640 - Browse repository at this point
Copy the full SHA 4002640View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb0f4d0 - Browse repository at this point
Copy the full SHA bb0f4d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 026a206 - Browse repository at this point
Copy the full SHA 026a206View commit details -
Configuration menu - View commit details
-
Copy full SHA for 121b454 - Browse repository at this point
Copy the full SHA 121b454View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ace3ba - Browse repository at this point
Copy the full SHA 5ace3baView commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c953770 - Browse repository at this point
Copy the full SHA c953770View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9921747 - Browse repository at this point
Copy the full SHA 9921747View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc571c5 - Browse repository at this point
Copy the full SHA dc571c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e0965e - Browse repository at this point
Copy the full SHA 8e0965eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0958d43 - Browse repository at this point
Copy the full SHA 0958d43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b37d1a - Browse repository at this point
Copy the full SHA 1b37d1aView commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f362972 - Browse repository at this point
Copy the full SHA f362972View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb7c419 - Browse repository at this point
Copy the full SHA eb7c419View commit details
Commits on Oct 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 922159a - Browse repository at this point
Copy the full SHA 922159aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.