[Siti Nadiah] iP #48
Open
[Siti Nadiah] iP #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo, Events, Deadlines
This reverts commit ec8b25f.
btricec
reviewed
Feb 4, 2020
src/main/java/Duke.java
Outdated
|
|
||
| System.out.println("What is up my dudes!\n" + tos); | ||
|
|
||
| String intro = "____________________________________________________________\n" + |
There was a problem hiding this comment.
Maybe you could use the LINE constant for this line?
src/main/java/Duke.java
Outdated
| } | ||
|
|
||
| private static void printWelcomeMessage() { | ||
| String tos = "──────────▄▄▄▄▄▄▄▄▄▄▄──────────\n" + |
src/main/java/Duke.java
Outdated
| taskNum--; | ||
| Tasks[taskNum].setDone(true); | ||
| printDone(Tasks[taskNum]); | ||
| } catch (ArrayIndexOutOfBoundsException e) { //If arr[1] does not exist |
There was a problem hiding this comment.
Looking at the Java Code Standards, it's better to make the comments in the next single line.
src/main/java/Duke.java
Outdated
|
|
||
| private static void printWelcomeMessage() { | ||
| String tos = "──────────▄▄▄▄▄▄▄▄▄▄▄──────────\n" + | ||
| "─────▄▄▀▀▀▀──────────▀▀▄▄──────\n" + |
src/main/java/Duke.java
Outdated
| System.out.println("Oops! Event description is incomplete!"); | ||
| } | ||
| break; | ||
| default: //unknown command |
There was a problem hiding this comment.
there is also a problem on where to comment. Please comment in a newline.
src/main/java/Duke.java
Outdated
|
|
||
| private static void runChatbot() { | ||
| Task[] Tasks = new Task[100]; | ||
|
|
There was a problem hiding this comment.
Delete some useless blank lines.
Add delete method
Add save method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.