[Wei Yang] iP #58
Open
[Wei Yang] iP #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2113-AY1920S2#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.
bennychanya
reviewed
Feb 4, 2020
src/main/java/Duke.java
Outdated
| @@ -1,10 +1,153 @@ | |||
| import java.awt.*; | |||
There was a problem hiding this comment.
Try to only import library that are necessary for your code
src/main/java/Duke.java
Outdated
| System.out.println("Here are the tasks in your list:"); | ||
| } | ||
| for (int i=0; i<userList.size(); i++) { | ||
| Integer index = i+1; |
There was a problem hiding this comment.
Should the naming be more specific? e.g. listIndex
src/main/java/Duke.java
Outdated
| ArrayList<String> words = new ArrayList<String>(Arrays.asList(userInput.split(" "))); | ||
| words.remove(0); | ||
| return new Todo (String.join(" ", words)); | ||
| } |
There was a problem hiding this comment.
Great way of initialization for your tasks
src/main/java/Duke.java
Outdated
| } | ||
| userInput = in.nextLine(); | ||
| } | ||
| System.out.print(lines + "Bye. Hope to see you again soon!\n" + lines); |
There was a problem hiding this comment.
Would it be clearer to get the userInput in another method rather than putting it in your botResponse method?
…rted files into package.
…e pass by value, ie object address are copied in params
Level 8 complete
Level 9 complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.