[Ho Jing Yang Daniel] ip #60

Bencotti · 2020-01-31T09:31:49Z

No description provided.

Add echo, datetime and exit features

This reverts commit 6abab68.

This has version creates new tasks as a task object, and stores each new task as an arrayList for dynamic storage. Code has improved user input validation to prevent breaking by undefined behaviour. A predefined command has to be used before activating a method.

Zhilin-Huang

Consider adding *.class in your .gitignore file so that you do not commit the binary .class files :)

Zhilin-Huang · 2020-02-04T06:17:11Z

src/main/java/Duke.java

+                System.out.println( "["+ currentTask.getTaskType() + "][" + currentTask.getStatusIcon() + "] " + currentTask.getDescription() + "\n");
+            }
+        } else {
+            System.out.println("Error: No such index in use\n");


Nice to take corner cases into account by specifying what to do when the task index is out of bound!

src/main/java/Task.java

text-ui-test/ACTUAL.TXT

Zhilin-Huang · 2020-02-04T06:25:15Z

src/main/java/Deadline.java

+    public void printListDetails(int count) {
+        System.out.println("["+ getTaskType() + "][" + super.getStatusIcon() + "] " + count + ". " + super.description + " (by: " + date + ")");
+    }
+


Possible redundant blank lines?

Zhilin-Huang · 2020-02-04T06:26:26Z

src/main/java/Duke.java

+    public static final int LENGTH_DEADLINE = 9;
+    public static final int LENGTH_EVENT = 6;
+    public static final int LENGTH_TODO = 5;
+    public static final int SIZE_DONE_COMMAND = 2;


Good job factoring out the constants!

Zhilin-Huang · 2020-02-04T06:27:02Z

src/main/java/Task.java

+        return null;
+    }
+
+    public void printAddDetails(int taskCounter) {


Consider refactoring the printAddDetails() function so that you don't need to duplicate part of the print statement in the child classes

Zhilin-Huang · 2020-02-04T06:28:33Z

src/main/java/Duke.java

+
+    public static void completeTask(ArrayList<Task> tasks, int taskIndex) {
+        taskIndex--; // index starts from 0, unlike listing number
+        if ( (taskIndex < tasks.size()) || (taskIndex > 0)) { // check if out of bounce


Minor typo: bounce -> bound

Zhilin-Huang · 2020-02-04T06:29:34Z

src/main/java/Duke.java

+        System.out.println("");
+    }
+
+    public static void printHelp() {


Great idea to provide a guide to help users understand how to use your bot :D

Zhilin-Huang · 2020-02-04T06:43:41Z

src/main/java/ToDo.java

+
+    @Override
+    public String getTaskType(){
+        return "T";


Consider making T a constant

Good suggestion!

JTWang2000

You've done a really good job for coding standard. Also, I really appreciate that you add additional features into your project to make it have your own design. There is only one small suggestion that you can do further abstraction to make the code cleaner. Overall, it is really a good work.

Review together with @yuchenlichuck

JTWang2000 · 2020-02-04T06:25:33Z

src/main/java/Duke.java

+            } else {
+                currentTask.markAsDone();
+                System.out.println("Nice! I've marked this task as done:");
+                System.out.println( "["+ currentTask.getTaskType() + "][" + currentTask.getStatusIcon() + "] " + currentTask.getDescription() + "\n");


This line is a little bit too long. Maybe you can split this line into two rows.

JTWang2000 · 2020-02-04T06:31:08Z

src/main/java/Duke.java

+        System.out.println("Commands: ");
+        System.out.println("List: lists all recorded tasks \nusage: list\n");
+        System.out.println("Done: mark task as completed \nusage: done <task number>\n");
+        System.out.println("Todo: Tasks without date/time \nUsage: todo <task> \n(Avoid using other keywords as the first word)\n");


You can consider to make this string into constant if you are going to use it for mutiple times.This can improve the readibility of the code.

JTWang2000 · 2020-02-04T06:36:27Z

src/main/java/Task.java

+    }
+
+    public void printAddDetails(int taskCounter) {
+        System.out.println("The following task has been added:\n[" + getTaskType() +"][" + getStatusIcon() + "] " + getDescription());


Please pay attention to line length. Try to keep line length shorter than 110 characters (soft limit). If the line exceeds the limit, use line wrapping at appropriate places of the line.

JTWang2000 · 2020-02-04T06:44:14Z

src/main/java/Duke.java

+
+    public static void completeTask(ArrayList<Task> tasks, int taskIndex) {
+        taskIndex--; // index starts from 0, unlike listing number
+        if ( (taskIndex < tasks.size()) || (taskIndex > 0)) { // check if out of bounce


There is a coding standard violation that between the first two barcekets, there should be no space.

JTWang2000 · 2020-02-04T06:45:16Z

src/main/java/Duke.java

+
+        System.out.println("\n" + logo + "\nYour Lifestyle Scheduling Assistant\n");
+        System.out.println("type \"help\" for list of commands");
+        System.out.println("____________________________________________________________\n");


If we print this long line mutiple times, we can make it a constant.

JTWang2000 · 2020-02-04T06:46:42Z

src/main/java/Duke.java

+                } catch (Exception e) {
+                    System.out.println("Please input a valid number\n");
+                }
+                break;


Inside the case "done": we can add a new function which extract these codes. It is not a coding standard violation, i am just commmenting to make your switch cases much cleaner.

Zhilin-Huang · 2020-02-04T06:52:31Z

Reviewed with @sliu107

…task

…onverted into checking size of arraylist

# Conflicts: # src/main/java/Duke/Duke.java

# Conflicts: # Duke/data.txt # src/main/java/Command/AddCommand.java # src/main/java/Duke/Deadline.java # src/main/java/Duke/Duke.java # src/main/java/Duke/Event.java # src/main/java/Duke/Task.java # src/main/java/Task/TaskList.java

Branch level 9

A java doc

Bencotti added 11 commits January 19, 2020 15:38

Level 1 Update

f9a4ecc

Add echo, datetime and exit features

Add save feature and listing of all saved tasks.

6abab68

Revert "Add save feature and listing of all saved tasks."

ba4ccbf

This reverts commit 6abab68.

Add save feature and listing of all recorded tasks

371a2de

Update code to comply with CS2113 Java coding standards

f6d7bf2

Change implementation of commands to follow assignment sample usage

4ac1e1e

Add support for tracking three types of tasks using inheritance

045d60e

Support display of event / deadline datetime

5459ba6

Automate text UI testing

97acd17

Improve code quality via refractoring and removal of magic numbers

445c672

Zhilin-Huang reviewed Feb 4, 2020

View reviewed changes

JTWang2000 reviewed Feb 4, 2020

View reviewed changes

Bencotti added 16 commits February 13, 2020 17:16

Update code to adhere closer to style guide after peer review

018f3cb

Update current exceptions to use proper Java built-in exceptions

184fec4

Refractor files into two packages - Exceptions or Duke

101781e

add exception for missing parameter and blank parameter for deadline …

b896d05

…task

add exception handling for Event and Todo tasks

0f813e7

Merge branch 'branch-Level-5'

e8f59a7

add delete function, remove dependancy on task counter variable and c…

ba35ca9

…onverted into checking size of arraylist

Add logic to write new tasks to file

74e7f23

update save logic, shift from task class to main

8418df9

add capability to read saved data from file and populate to list

ad533a9

Merge branch 'branch-Level-7'

e9fb013

Merge branch 'branch-Level-6'

b2d6d33

# Conflicts: # src/main/java/Duke/Duke.java

Fix list not updating after delete

f03c251

Add validation to check if data file exists before populating list

960018b

update git ignore file

4fe03b1

Remove unused libries and tidy code

727b86d

Bencotti added 27 commits February 24, 2020 20:55

Reractor methods into corresponding classes

4490216

Alter logical flow of code to use more objects

0e7ec06

Convert task date from string to LocalTime

0bfbddf

Add exception handling for new datetime format

4d8d986

Add search feature via given keyword

f3468be

Add Javadoc

c9416ac

Merge branch 'master' into branch-Level-8

72b98b6

Merge remote-tracking branch 'origin/branch-Level-8'

900134e

Merge branch 'master' into branch-Level-9

2c3a26c

Merge branch 'master' into A-JavaDoc

721d902

# Conflicts: # Duke/data.txt # src/main/java/Command/AddCommand.java # src/main/java/Duke/Deadline.java # src/main/java/Duke/Duke.java # src/main/java/Duke/Event.java # src/main/java/Duke/Task.java # src/main/java/Task/TaskList.java

Merge pull request #2 from Bencotti/branch-Level-9

c013b71

Branch level 9

Merge branch 'master' into A-JavaDoc

21db93a

Merge pull request #3 from Bencotti/A-JavaDoc

a413c5b

A java doc

Resolve merge conflicts

0211ada

Add user guide

423172a

Set theme jekyll-theme-cayman

d6e3556

Set theme jekyll-theme-slate

5f1babf

Set theme jekyll-theme-slate

5d9a84f

Set theme jekyll-theme-cayman

a715778

Edit code to adhere closer to style guide

211d022

Merge branch 'master' of https://github.com/Bencotti/duke

179fa3a

Remove html tags from readme

f25466a

Fix README not displaying properly

3983f5a

Fix REDAME not displaying "List"

db1b11b

Fix point 5 an 6 not displaying properly

da193d5

Fix item 2 in README not displaying

fcb06d4

Fix README Item 3.1 not displaying properly

187b2a7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ho Jing Yang Daniel] ip #60

[Ho Jing Yang Daniel] ip #60

Bencotti commented Jan 31, 2020

Zhilin-Huang left a comment

Zhilin-Huang Feb 4, 2020

Zhilin-Huang Feb 4, 2020

Zhilin-Huang Feb 4, 2020

Zhilin-Huang Feb 4, 2020

Zhilin-Huang Feb 4, 2020

Zhilin-Huang Feb 4, 2020

Zhilin-Huang Feb 4, 2020

Bencotti Feb 13, 2020

JTWang2000 left a comment

JTWang2000 Feb 4, 2020

JTWang2000 Feb 4, 2020

JTWang2000 Feb 4, 2020

JTWang2000 Feb 4, 2020

JTWang2000 Feb 4, 2020

JTWang2000 Feb 4, 2020

Zhilin-Huang commented Feb 4, 2020

[Ho Jing Yang Daniel] ip #60

Are you sure you want to change the base?

[Ho Jing Yang Daniel] ip #60

Conversation

Bencotti commented Jan 31, 2020

Zhilin-Huang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JTWang2000 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zhilin-Huang commented Feb 4, 2020