Ananda Lye iP #65
Open
Ananda Lye iP #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowxizhi
reviewed
Feb 4, 2020
src/main/java/Duke.java
Outdated
| String goodbye = "Bye. Hope to see you again soon!"; | ||
| System.out.println(greeting); | ||
|
|
||
| Task[] tasklist = new Task[100]; |
src/main/java/Duke.java
Outdated
| Task[] tasklist = new Task[100]; | ||
|
|
||
| Scanner scanner = new Scanner(System.in); | ||
| int flag = 0; |
There was a problem hiding this comment.
variable names can be more descriptive to facilitate understanding.
use boolean type instead of int type, phrase like a question eg. isExit
src/main/java/Duke.java
Outdated
|
|
||
| Scanner scanner = new Scanner(System.in); | ||
| int flag = 0; | ||
| int index = 0; |
There was a problem hiding this comment.
variable names can be more descriptive to facilitate understanding
src/main/java/Duke.java
Outdated
| System.out.print(".[" + tasklist[i-1].getStatusIcon() + "] " + tasklist[i-1].description + "\n"); | ||
| } | ||
| } else if (userinput.startsWith("done")){ | ||
| String IndexOfItem = userinput.substring(5); |
src/main/java/Duke.java
Outdated
| } | ||
| } else if (userinput.startsWith("done")){ | ||
| String IndexOfItem = userinput.substring(5); | ||
| int ID = Integer.valueOf(IndexOfItem) - 1; |
There was a problem hiding this comment.
use descriptive names to differentiate between int type and String type variable
eg. "indexString" & "indexInt"
src/main/java/Task.java
Outdated
| } | ||
|
|
||
|
|
||
| public String markAsdone () { |
…g exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.