[CS2113-T17-4] NUSDegs #29

SebasFok · 2023-10-06T09:39:01Z

NUSDegs streamlines computing degree planning by offering personalized module schedules, tracking progress, and ensuring on-time graduation. It eliminates guesswork, reduces stress, and saves time and money for students while providing data-driven insights for academic institutions. It's a comprehensive tool for efficient and successful degree completion.

Show saved flashcardList size

YongbinWang

Overall good job. Tackling prerequisites and an external API is difficult but the implementation looks good so far. There needs to be more standardization throughout the project such as using a common Ui class, naming convention. There can also be better abstraction of your implementations by breaking down the logic into methods and using different command classes to handle different user inputs.

YongbinWang · 2023-10-29T05:15:32Z

src/main/java/seedu/duke/models/schema/Student.java

+        if (words.length < 2) {
+            return "currentMajor";
+        }


Consider abstracting this into a clearer method to illustrate what you are trying to achieve.

YongbinWang · 2023-10-29T05:19:15Z

src/main/java/seedu/duke/models/schema/Student.java

+    }
+
+    public String updateMajor(String userInput) {
+        String[] words = userInput.split(" ");


Consider avoiding magic literals by using a constant for " ".

YongbinWang · 2023-10-29T05:21:19Z

src/main/java/seedu/duke/controllers/ModulePlannerController.java

+            case "hi": {
+                view.displayMessage("can put the commands here");
+                break;
+            }
+            case "hello": {


I guess this was used for initial local testing, please remember to remove it.

YongbinWang · 2023-10-29T05:21:49Z

src/main/java/seedu/duke/controllers/ModulePlannerController.java

+
+            String[] words = userInput.split(" ");
+
+            String initialWord = words[0].toLowerCase();


Consider using a better variable name for initialWord, maybe command.

YongbinWang · 2023-10-29T05:23:08Z

src/main/java/seedu/duke/controllers/ModulePlannerController.java

+            case "major": {
+                String printMessageCommand = student.updateMajor(userInput);
+                switch (printMessageCommand) {
+                case "currentMajor":
+                    view.displayMessage("Current major is " + student.getMajor() + ".");
+                    break;
+                case "newMajor":
+                    view.displayMessage("Major " + student.getMajor() + " selected!");
+                    break;
+                case "invalidMajor":


Consider abstracting out into different Command classes. Extensive use of magic literals here, try to avoid them.

YongbinWang · 2023-10-29T05:31:07Z

src/main/java/seedu/duke/models/logic/Api.java

+            System.out.println("Invalid Module Name");
+        } catch (IOException | InterruptedException e) {
+            System.out.println("Invalid Module Name");


Consider using a standardized Ui object to print output onto command line. The ModulePlannerController class is using CommandLineView.

YongbinWang · 2023-10-29T05:37:08Z

src/main/java/seedu/duke/models/logic/ModuleList.java

+    public void getDifference (ModuleList a, ModuleList b) throws InvalidObjectException {
+        //A - B
+        if (a == null || b == null) {
+            throw new InvalidObjectException("Null Inputs");


Consider using clearer variable names for your ModuleLists.

YongbinWang · 2023-10-29T05:39:09Z

src/main/java/seedu/duke/models/logic/ModuleList.java

+     * @return true if the module exists in the list; false otherwise.
+     * @throws InvalidObjectException If moduleA is null.
+     */
+    public boolean exists(String moduleA) throws InvalidObjectException {


Boolean method should have prefix such as is, has, was.

YongbinWang · 2023-10-29T05:45:34Z

src/main/java/seedu/duke/models/logic/CompletePreqs.java

+                System.out.println(moduleCompleted +
+                        " cannot be marked as completed because of uncompleted prerequisites: "
+                        + unmetPrerequisites);


Consider using a standardized Ui object to execute your outputs. Avoid long strings, convert it to constants.

YongbinWang · 2023-10-29T05:46:36Z

src/main/java/seedu/duke/models/logic/CompletePreqs.java

+        for (String key : modulesWithPreqs.keySet()) {
+            //If new unlocked mod isn't marked as complete or unlocked already
+            if (!unlockedModulesSet.contains(key) && !addToModulesCompleted.contains(key)) {
+                boolean allPrerequisitesMet = true;


Boolean variable should also have prefix such as is, has etc.

ICubE- · 2023-11-01T04:17:55Z

docs/DeveloperGuide.md

@@ -4,9 +4,123 @@

 {list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}

-## Design & implementation
+## Design & implementation, Architecture

 {Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}


It would be better to understand if there is a diagram for what you implemented.

ICubE- · 2023-11-01T04:22:44Z

docs/DeveloperGuide.md

+- Required
+
+# Implementation
+


Maybe some developers would want to know how the user input is handled.

ICubE- · 2023-11-01T04:27:45Z

docs/DeveloperGuide.md

+
+Response:
+`CS2030S CS2040S CS2100 CS2101 CS2106 CS2109S CS3230`
+


What data structure do you use to record the modules that user has taken?
How do you collect the modules data that user has taken?

Jonoans

I think the DG could have more diagrams :D

Jonoans · 2023-11-01T04:08:59Z

docs/DeveloperGuide.md

@@ -4,9 +4,123 @@

 {list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}

-## Design & implementation
+## Design & implementation, Architecture


Maybe it would be helpful to include diagrams to illustrate the program flow?

Jonoans · 2023-11-01T04:22:59Z

docs/DeveloperGuide.md

+
+#### Example 1: Calculate Remaining MCs
+
+Command: `pace Y2/S1` (assuming that the user has completed 60 MCs from Y1S1 to Y2S1)


Would it be helpful to have information about the parameter's use?

Jonoans · 2023-11-01T04:27:36Z

docs/DeveloperGuide.md

+Command: `required`
+
+Response:
+Module requirements for major selected by user


 ## Product scope


Would it help to include more user stories?

…for timetable function

…o-timetable-modify Rohit/feat/add clear command to timetable modify

Add integration testing for add and delete features

…ts-info-and-search Update integration test for info and search features

Refactor while loop for timetable function

…q, recommended and delete function (#180) * Fix issue where application crashes when wifi is off(add, shift,prereq, recommended and delete function * Fix test bug * fix checkstyletest * Fix checkstyle * fix unit test * erm * fix unit test

…mer to user guide (#181)

#135

…pdate User Input format for TimetableMode

Rohit/fix/update ug dg

ppp

Add DG for clear feature

Rohit/fix/update ug dg

Update for DG Conclusion

Update ppp

ppp formatting

Brian030601 pushed a commit to Brian030601/tp that referenced this pull request Oct 19, 2023

Merge pull request nus-cs2113-AY2324S1#29 from junhyeong0411/master

0c057fa

Show saved flashcardList size

YongbinWang reviewed Oct 29, 2023

View reviewed changes

ICubE- reviewed Nov 1, 2023

View reviewed changes

docs/DeveloperGuide.md

- Required

# Implementation

Copy link

ICubE- Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some developers would want to know how the user input is handled.

ICubE- reviewed Nov 1, 2023

View reviewed changes

Jonoans reviewed Nov 1, 2023

View reviewed changes

ryanlohyr and others added 24 commits November 9, 2023 14:29

Added while statement to timetable function, commented out unit code …

7a22ad8

…for timetable function

Fix image issues on the UserGuide.md

9651f16

Add few more cases for delete test

2dcf3c6

Fix image issues on the UserGuide.md

d685ab2

Merge branch 'master' into SebasFok/test/addAndDelete

44aa0fc

Fix checkstyle test

cd732e8

Fix image issues on the UserGuide.md

2aed76b

Merge pull request #175 from rohitcube/rohit/feat/add-clear-command-t…

b281b3a

…o-timetable-modify Rohit/feat/add clear command to timetable modify

Merge pull request #178 from SebasFok/SebasFok/test/addAndDelete

f3052b5

Add integration testing for add and delete features

Update integration test for info and search features

9ae1bbf

Merge pull request #179 from rohitcube/rohit/feat/add-integration-tes…

53f24ac

…ts-info-and-search Update integration test for info and search features

Merge pull request #177 from ryanlohyr/ryan/enhance/timetable

0938e8a

Refactor while loop for timetable function

incomplete changes to TimetableParser

5eb5353

Added Complete Feature Integration Tests and added preclusion discali…

9486986

…mer to user guide (#181)

Add InvalidTimetableUserCommandException and TimetableUserCommand class

e394f24

#135

Merge

6f81557

Merge pull request #182 from janelleenqi/Janelle/fix/TimetableParserU…

43e0c7e

…pdate User Input format for TimetableMode

Added module credits logic (#183)

71e0978

update new modify function

25aac60

allow multiple spaces for userinput, tabs are NOT ALLOWED

b3a818e

merge

00d194b

checkstyle

3640d9c

update screenshots fixes #141

c5683f6

rohitcube and others added 30 commits November 14, 2023 02:08

Merge pull request #240 from rohitcube/rohit/fix/update-UG-DG

d0655a3

Rohit/fix/update ug dg

Update userguide (#242)

0ca9462

Left and Required Feature DG update

e6946b3

update dg and ppp

640eea3

Merge branch 'master' into rohit/fix/update-UG-DG

3bd1cf7

Merge pull request #243 from rohitcube/rohit/fix/update-UG-DG

4fe7b69

ppp

Add DG for storage and clear feature

37453d4

Merge branch 'master' into SebasFok/docs/DGforClear

20892fb

Update clear diagram

d9dd67c

Merge pull request #244 from SebasFok/SebasFok/docs/DGforClear

f166530

Add DG for clear feature

DG && PPP update

15e2e97

update errors in dg and update images in ppp

7bd0ffe

Merge branch 'master' into rohit/fix/update-UG-DG

1618302

Merge pull request #245 from rohitcube/rohit/fix/update-UG-DG

bd3da9c

Rohit/fix/update ug dg

merge

b29f1c8

merge

9db656e

Update DG conclusion

01b0ee4

Update PPP

5c43119

Merge branch 'master' into SebasFok/dics/PPP

474fa12

Fix additional pointer

c7df252

update

9d01c81

Fix typo

8522cdb

Merge pull request #246 from janelleenqi/Janelle/guide/finals

a6acff2

Update for DG Conclusion

Merge branch 'master' into SebasFok/dics/PPP

01ff295

Final changese to PPP and DG

bfa255f

Merge pull request #247 from SebasFok/SebasFok/dics/PPP

ff795b3

Update ppp

Update Isaiah PPP (#248)

e8fa068

Resize image

3c665ad

Merge branch 'master' into SebasFok/docs/PPPformatting

57cfae6

Merge pull request #249 from SebasFok/SebasFok/docs/PPPformatting

5205b70

ppp formatting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2113-T17-4] NUSDegs #29

[CS2113-T17-4] NUSDegs #29

SebasFok commented Oct 6, 2023

YongbinWang left a comment

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

YongbinWang Oct 29, 2023

ICubE- Nov 1, 2023 •

edited

Loading

ICubE- Nov 1, 2023

ICubE- Nov 1, 2023

Jonoans left a comment

Jonoans Nov 1, 2023

Jonoans Nov 1, 2023

Jonoans Nov 1, 2023


		String[] words = userInput.split(" ");

		String initialWord = words[0].toLowerCase();


		Response:
		`CS2030S CS2040S CS2100 CS2101 CS2106 CS2109S CS3230`


		#### Example 1: Calculate Remaining MCs

		Command: `pace Y2/S1` (assuming that the user has completed 60 MCs from Y1S1 to Y2S1)

[CS2113-T17-4] NUSDegs #29

Are you sure you want to change the base?

[CS2113-T17-4] NUSDegs #29

Conversation

SebasFok commented Oct 6, 2023

YongbinWang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ICubE- Nov 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jonoans left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ICubE- Nov 1, 2023 •

edited

Loading