[Huang Maodian] iP #190
Open
[Huang Maodian] iP #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comply with coding standard.
ChoonSiang
reviewed
Feb 20, 2024
src/main/java/huan/main/Huan.java
Outdated
| @@ -0,0 +1,142 @@ | |||
| package huan.main; | |||
|
|
|||
| import huan.task.*; | |||
There was a problem hiding this comment.
Avoid importing *, try to explicitly list out the import classes
src/main/java/huan/main/Huan.java
Outdated
| } | ||
| } | ||
| } | ||
| public static void readProcessCommand() { |
There was a problem hiding this comment.
Very long method, maybe try to abstract each command?
src/main/java/huan/main/Huan.java
Outdated
| String firstWord = words[0]; | ||
| String suffixWord; | ||
| if(words.length > 1) { | ||
| suffixWord = inputCommand.substring(words[0].length() + 1); |
There was a problem hiding this comment.
Multiple usage of Magic numbers, try to assign the number with a meaningful variable name for easy understand of what the number is for.
| String[] words = nameWithDate.split(" "); | ||
| /* | ||
| state: | ||
| 0 means currently concatenating name |
There was a problem hiding this comment.
Can consider using ENUM instead of 0,1 for the state
| import java.util.Objects; | ||
|
|
||
| public class DeadlineTask extends Task{ | ||
| private String ddlTime; |
There was a problem hiding this comment.
maybe can consider calling it deadlineTime, as ddlTime can be hard to understand what it means
| } | ||
| } | ||
| } | ||
| if(state != 2 || name.toString().isEmpty() || startTime.toString().isEmpty() || endTime.toString().isEmpty()) { |
There was a problem hiding this comment.
very long and complicated statement, can consider splitting it up
…ng deadline tasks before a specific time.
Add date time recognition in DeadlineTasks, and a command for filteri…
Add 'find' feature that allows filtering tasks by matching names
Add Javadoc Comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.