-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Praneet-25] iP #191
base: master
Are you sure you want to change the base?
[Praneet-25] iP #191
Conversation
…y them back to the user when requested.
…s, add the ability to change the status back to not done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to merge code to your master branch and push the code. The PR doesn't seem to have progressed in a long time.
I hope these review comments help in polishing the iP code before submission.
src/main/java/Deadline.java
Outdated
} | ||
|
||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coding standard violation here.
src/main/java/Duke.java
Outdated
|
||
static ArrayList<Task> listOfItems = new ArrayList<>(); | ||
|
||
//variable stores the number of tasks being added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant comment
src/main/java/Duke.java
Outdated
public static void main(String[] args) { | ||
String logo = " ____ _ \n" | ||
+ "| _ \\ _ _| | _____ \n" | ||
+ "| | | | | | | |/ / _ \\\n" | ||
+ "| |_| | |_| | < __/\n" | ||
+ "|____/ \\__,_|_|\\_\\___|\n"; | ||
System.out.println("Hello from\n" + logo); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main method is doing a lot of things. please follow the instructions in A-MoreOOP and refactor the code accordingly.
src/main/java/Duke.java
Outdated
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary blank space
src/main/java/Task.java
Outdated
task = new Deadline(description); // Create Deadline task | ||
break; | ||
case "E": | ||
task = new Event(description); // Create Event task | ||
break; | ||
case "T": | ||
task = new ToDo(description); // Create Todo task | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant comments
Add find functionality
# Conflicts: # src/main/java/Duke.java # src/main/java/Storage.java # src/main/java/TaskList.java # src/main/java/ToDo.java # src/main/java/Ui.java
No description provided.