Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Praneet-25] iP #191

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Conversation

Praneet-25
Copy link

No description provided.

Copy link

@okkhoy okkhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to merge code to your master branch and push the code. The PR doesn't seem to have progressed in a long time.
I hope these review comments help in polishing the iP code before submission.

Comment on lines 12 to 14
}

else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coding standard violation here.


static ArrayList<Task> listOfItems = new ArrayList<>();

//variable stores the number of tasks being added
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant comment

public static void main(String[] args) {
String logo = " ____ _ \n"
+ "| _ \\ _ _| | _____ \n"
+ "| | | | | | | |/ / _ \\\n"
+ "| |_| | |_| | < __/\n"
+ "|____/ \\__,_|_|\\_\\___|\n";
System.out.println("Hello from\n" + logo);


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main method is doing a lot of things. please follow the instructions in A-MoreOOP and refactor the code accordingly.

Comment on lines 199 to 206








Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary blank space

Comment on lines 37 to 44
task = new Deadline(description); // Create Deadline task
break;
case "E":
task = new Event(description); // Create Event task
break;
case "T":
task = new ToDo(description); // Create Todo task
break;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants