Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113-T12-4] Omnitravel #36

Open
wants to merge 462 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
462 commits
Select commit Hold shift + click to select a range
59523c6
Edit save text file
Apr 1, 2024
0888f30
Merge remote-tracking branch 'upstream/master'
Apr 1, 2024
d013733
Fix print outputs
Apr 1, 2024
7287ea4
Add CheckParameters class to handle input exceptions
Apr 1, 2024
264d166
Add CheckParameters class to handle input exceptions
Apr 1, 2024
9e97d0e
Merge pull request #114 from EugeneChanJiajun/throw-exception-class
daryltay415 Apr 1, 2024
c4ef836
Fix bugs
daryltay415 Apr 1, 2024
6de20bd
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 1, 2024
1c117e6
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 1, 2024
a163433
Gradle fix
daryltay415 Apr 1, 2024
3d46a95
Merge pull request #116 from daryltay415/master
daryltay415 Apr 1, 2024
97e873f
extract log method and save file
Apr 1, 2024
e72019c
Update UI class
daryltay415 Apr 1, 2024
5046e1a
Merge pull request #118 from EugeneChanJiajun/master
EugeneChanJiajun Apr 1, 2024
7e8d9de
Add packages
daryltay415 Apr 1, 2024
f62593a
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 1, 2024
d94bc34
update userguide
Apr 1, 2024
672fce8
Merge pull request #120 from EugeneChanJiajun/master
EugeneChanJiajun Apr 1, 2024
e852cb0
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 1, 2024
f9f62f5
Fix package violation
daryltay415 Apr 1, 2024
0bf9ff1
Update javadoc
daryltay415 Apr 1, 2024
cb17222
Fix package
daryltay415 Apr 1, 2024
d16dc27
Merge pull request #121 from daryltay415/master
EugeneChanJiajun Apr 1, 2024
2773768
update user guide
EugeneChanJiajun Apr 1, 2024
9865b47
Update userguide
EugeneChanJiajun Apr 1, 2024
f01b15c
Merge pull request #123 from EugeneChanJiajun/master
daryltay415 Apr 1, 2024
c834996
Fix update function
daryltay415 Apr 1, 2024
20bfc8c
Merge pull request #124 from daryltay415/master
EugeneChanJiajun Apr 1, 2024
7381df2
update user guide and developer guide
Apr 2, 2024
67c407d
Add overview class diagram to developer guide
daryltay415 Apr 2, 2024
8b97fa2
Merge pull request #125 from EugeneChanJiajun/master
daryltay415 Apr 2, 2024
a9824ae
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 2, 2024
125a4c7
Merge pull request #126 from daryltay415/master
EugeneChanJiajun Apr 2, 2024
fda1646
merge findJunit branch into main
ChinYanXu Apr 2, 2024
8339e0e
Merge branch 'master' of github.com:AY2324S2-CS2113-T12-4/tp
ChinYanXu Apr 2, 2024
7ce04f8
Edit UserGuide.md and findCommand error message
ChinYanXu Apr 2, 2024
adcb3ad
Merge pull request #127 from ChinYanXu/UserGuide1
ChinYanXu Apr 2, 2024
f391b2c
Update expense function
daryltay415 Apr 3, 2024
8634ab4
updated user guide w check, uncheck, total expense
annnniexu Apr 3, 2024
891f521
Merge pull request #129 from annnniexu/master
daryltay415 Apr 3, 2024
3fa653f
Merge pull request #128 from daryltay415/master
daryltay415 Apr 3, 2024
c9d7983
Update developer guide
daryltay415 Apr 3, 2024
ffe1db2
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 3, 2024
9752e83
update userguide format
ChenKangg Apr 3, 2024
b30f4ec
Add sequence diagram for lookup functions
ChinYanXu Apr 3, 2024
61322b6
Merge branch 'master' of https://github.com/ChenKangg/tp
ChenKangg Apr 3, 2024
4739b2d
update userguide
ChenKangg Apr 3, 2024
fdeb1ef
Merge pull request #130 from ChinYanXu/UserGuide1
ChinYanXu Apr 3, 2024
a70f890
Merge pull request #131 from ChenKangg/master
ChenKangg Apr 3, 2024
c3e02d8
merge UserGuide1 into master
ChinYanXu Apr 3, 2024
f774ac0
Merge branch 'master' of github.com:AY2324S2-CS2113-T12-4/tp
ChinYanXu Apr 3, 2024
80a39a7
Add assertions to lookup functions
ChinYanXu Apr 3, 2024
72aab9d
Merge pull request #132 from ChinYanXu/NewAssertions
ChinYanXu Apr 3, 2024
f6333ab
added sequence diagram for total expense feature
annnniexu Apr 3, 2024
be60e42
added total expense function
annnniexu Apr 3, 2024
00aee27
fixed style errors
annnniexu Apr 3, 2024
cfa7cb4
Update developer guide
EugeneChanJiajun Apr 3, 2024
5213a22
Merge pull request #133 from annnniexu/master
daryltay415 Apr 3, 2024
0b2f8cb
Merge pull request #134 from EugeneChanJiajun/master
daryltay415 Apr 3, 2024
b33ae42
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 3, 2024
7474b7b
Add jar file v2.0
daryltay415 Apr 3, 2024
57f25ec
Merge pull request #135 from daryltay415/master
daryltay415 Apr 4, 2024
137b914
Add exchange API
daryltay415 Apr 5, 2024
b72f5c7
Add ability to list tags
daryltay415 Apr 5, 2024
7d57396
Add Junit tests
EugeneChanJiajun Apr 6, 2024
404213c
Bug fixes from PED
EugeneChanJiajun Apr 6, 2024
37b69dc
Bug fix for PED
EugeneChanJiajun Apr 6, 2024
b3fa1ca
Bug fix for PED
EugeneChanJiajun Apr 6, 2024
7af7d40
Bug fix for PED
EugeneChanJiajun Apr 6, 2024
75a98ae
Bug fix for PED
EugeneChanJiajun Apr 6, 2024
67a2b96
Fix bugs based on issues
daryltay415 Apr 6, 2024
4fc6850
Bug fix for PED
EugeneChanJiajun Apr 6, 2024
396338b
Merge pull request #192 from EugeneChanJiajun/master
daryltay415 Apr 6, 2024
d25ae04
Merge remote-tracking branch 'upstream/master' into branch-tag-list
daryltay415 Apr 6, 2024
657ecf1
FIx gradle bug
daryltay415 Apr 6, 2024
162066f
Merge pull request #193 from daryltay415/branch-tag-list
EugeneChanJiajun Apr 6, 2024
451638c
Added new javadocs
EugeneChanJiajun Apr 6, 2024
31211b4
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 6, 2024
d23e6dd
Merge branch 'master' into branch-currency-exchange
daryltay415 Apr 7, 2024
00ad20c
Add currency exchange API
daryltay415 Apr 7, 2024
d244686
Fix checkstyle
daryltay415 Apr 7, 2024
a9c3d3c
Merge pull request #195 from daryltay415/branch-currency-exchange
EugeneChanJiajun Apr 7, 2024
c1b71d9
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 7, 2024
af42f4b
Add Junit test for parser class
EugeneChanJiajun Apr 7, 2024
75b06b9
Merge pull request #197 from EugeneChanJiajun/master
daryltay415 Apr 8, 2024
4ad8705
update userguide and bug fix
Apr 8, 2024
cd4071c
Update developer guide
daryltay415 Apr 8, 2024
5f68f0b
Merge pull request #198 from EugeneChanJiajun/master
daryltay415 Apr 8, 2024
0946029
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 8, 2024
289b16a
Refactor loadFileContents
ChinYanXu Apr 8, 2024
482d168
Merge NewAssertions branch to master
ChinYanXu Apr 8, 2024
7b2a641
Bug fix and userguide updates
Apr 8, 2024
4bc2e5a
Bug fix and userguide update
Apr 8, 2024
318cad0
Merge pull request #200 from EugeneChanJiajun/master
daryltay415 Apr 8, 2024
d2de866
Fix update function
daryltay415 Apr 8, 2024
a5c75ec
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 8, 2024
03ebc12
Fix update test
daryltay415 Apr 8, 2024
2c67e13
implement add remove find location + junit
ChenKangg Apr 8, 2024
d86ef9e
Merge pull request #201 from ChenKangg/master
ChenKangg Apr 8, 2024
4a4c025
Merge pull request #199 from ChinYanXu/NewAssertions
ChinYanXu Apr 8, 2024
7e3736f
Update developer guide
daryltay415 Apr 8, 2024
4d1ddde
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 8, 2024
9eb038c
update location + help command
ChenKangg Apr 8, 2024
cbbdbdc
Merge pull request #202 from ChenKangg/master
ChenKangg Apr 8, 2024
4db31ef
Update parser
EugeneChanJiajun Apr 8, 2024
66af77e
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 8, 2024
49223bc
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 8, 2024
f27556a
Merge pull request #203 from daryltay415/master
daryltay415 Apr 8, 2024
28014b7
add location to list
ChenKangg Apr 8, 2024
d77928a
Add JUnit test for total expense function
ChinYanXu Apr 8, 2024
89ebba8
Merge pull request #204 from ChenKangg/master
ChenKangg Apr 8, 2024
0ea8c89
Add junit test
EugeneChanJiajun Apr 8, 2024
314b1d4
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 8, 2024
5cfac12
Edit omni.txt
ChinYanXu Apr 8, 2024
4e14c8d
omni.txt
ChinYanXu Apr 8, 2024
de29041
Merge branch 'TotalExpenseJunit'
ChinYanXu Apr 8, 2024
8fb864d
Edit UserGuide for clarity
ChinYanXu Apr 8, 2024
2b3d8e8
Merge pull request #206 from ChinYanXu/UpdateGUI
EugeneChanJiajun Apr 8, 2024
7900ac4
Add PPP
EugeneChanJiajun Apr 8, 2024
12e9154
Update PPP -Daryl
daryltay415 Apr 8, 2024
8e1c4a2
Merge remote-tracking branch 'upstream/master' into branch-ppp
daryltay415 Apr 8, 2024
f21e0c3
Merge pull request #207 from EugeneChanJiajun/master
daryltay415 Apr 8, 2024
04a882d
Merge remote-tracking branch 'upstream/master' into branch-ppp
daryltay415 Apr 8, 2024
0c916e6
Merge pull request #209 from daryltay415/branch-ppp
EugeneChanJiajun Apr 8, 2024
b6918cb
add ppp
ChenKangg Apr 8, 2024
0590f1b
Merge pull request #210 from ChenKangg/master
daryltay415 Apr 8, 2024
fe640b3
Enhanced delete function with keyword delete functionality
ChinYanXu Apr 8, 2024
338ca75
Enhanced delete function with keyword delete functionality
ChinYanXu Apr 8, 2024
8b6b2c1
Add Junit for delete function delete keyword functionality
ChinYanXu Apr 8, 2024
398f682
Edit User Guide to include delete functionality enhancement
ChinYanXu Apr 8, 2024
fc60e2c
Add valid test inputs to Junit test functions
ChinYanXu Apr 8, 2024
8ed4232
Merge branch 'master' into DeleteFunctionEnhancement
ChinYanXu Apr 8, 2024
87aefa9
Merge pull request #211 from ChinYanXu/DeleteFunctionEnhancement
EugeneChanJiajun Apr 9, 2024
5b6bd74
Bug fix
Apr 9, 2024
50c149c
Merge remote-tracking branch 'upstream/master'
Apr 9, 2024
f5df6bb
update userguide
ChenKangg Apr 9, 2024
27d872d
update tag userguide
ChenKangg Apr 9, 2024
12cba98
Bug fix
Apr 9, 2024
6ac7a69
remove help command
ChenKangg Apr 9, 2024
584a8b4
Merge pull request #213 from EugeneChanJiajun/master
daryltay415 Apr 9, 2024
2228fad
Merge branch 'master' into master
ChenKangg Apr 9, 2024
9c977c5
rename ppp
ChenKangg Apr 9, 2024
a7c8fcd
Merge branch 'master' of https://github.com/ChenKangg/tp
ChenKangg Apr 9, 2024
bb0515c
add exclude functionality to find function and added tests for the ex…
ChinYanXu Apr 9, 2024
3dc286e
bug fix
EugeneChanJiajun Apr 9, 2024
be80b9a
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 9, 2024
d765a97
Add exclude functionality for findtag and findtype function. Add Juni…
ChinYanXu Apr 9, 2024
effafc3
Add valid test inputs to Junit tests
ChinYanXu Apr 9, 2024
859d4cb
Update listtags
daryltay415 Apr 9, 2024
20fc87e
Merge remote-tracking branch 'upstream/master' into branch-ppp
daryltay415 Apr 9, 2024
8081f1a
Update code reposense
daryltay415 Apr 9, 2024
8035987
Merge pull request #212 from ChenKangg/master
daryltay415 Apr 9, 2024
9263ecd
Merge remote-tracking branch 'upstream/master' into branch-ppp
daryltay415 Apr 9, 2024
2babfeb
Merge pull request #215 from daryltay415/branch-ppp
daryltay415 Apr 9, 2024
bd5bfe6
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 9, 2024
1bd0866
Fix consecutive items not deleted bug in removeTravelActivity function
ChinYanXu Apr 9, 2024
fc32865
Merge local repo with online repo
ChinYanXu Apr 9, 2024
81de061
Merge branch 'master' into DeleteFunctionEnhancement
ChinYanXu Apr 9, 2024
32e096a
Add PPP and fix junit
ChinYanXu Apr 9, 2024
326bc6e
Add PPP and fix JUnit
ChinYanXu Apr 9, 2024
ad66e9e
Fix JUnit
ChinYanXu Apr 9, 2024
254f0b2
Merge pull request #216 from ChinYanXu/DeleteFunctionEnhancement
ChinYanXu Apr 10, 2024
e8fe319
Rename ChinYanXu.md to chinyanxu.md
ChinYanXu Apr 10, 2024
6f8bdf7
Merge pull request #217 from AY2324S2-CS2113-T12-4/ChinYanXu-patch-1
daryltay415 Apr 10, 2024
b7776f7
added sort to list
annnniexu Apr 10, 2024
8232670
resolved merge conflicts
annnniexu Apr 10, 2024
3c6efff
added javadoc comments
annnniexu Apr 11, 2024
152cedd
Merge pull request #218 from annnniexu/master
daryltay415 Apr 11, 2024
1aacdb6
update docs
ChenKangg Apr 11, 2024
db0314e
updated userguide and added ppp
annnniexu Apr 12, 2024
a831c1b
Merge pull request #219 from ChenKangg/master
daryltay415 Apr 12, 2024
9155347
Merge pull request #220 from annnniexu/master
daryltay415 Apr 12, 2024
6154d6e
Bug fix
daryltay415 Apr 12, 2024
5d538c7
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 12, 2024
96ad643
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 12, 2024
f10b00c
Merge DeleteFunctionEnhancement branch to master branch
ChinYanXu Apr 12, 2024
e1fff42
Merge branch 'master' of github.com:AY2324S2-CS2113-T12-4/tp
ChinYanXu Apr 12, 2024
32ae783
Add new class diagram for save function
EugeneChanJiajun Apr 12, 2024
2e32714
Update developer guide and userguide
daryltay415 Apr 12, 2024
9ca74e9
Merge pull request #221 from EugeneChanJiajun/master
daryltay415 Apr 12, 2024
48c9b7c
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 12, 2024
92556fc
Merge pull request #222 from daryltay415/master
EugeneChanJiajun Apr 12, 2024
6c6c20b
Bug fix
EugeneChanJiajun Apr 12, 2024
2736530
bug fix
EugeneChanJiajun Apr 12, 2024
da07f1e
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 12, 2024
538e94a
Update user guide
EugeneChanJiajun Apr 12, 2024
d6dfa93
Merge pull request #223 from EugeneChanJiajun/master
daryltay415 Apr 12, 2024
3eb74f3
Add parser test commands to junit testing
daryltay415 Apr 12, 2024
5773b2b
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 12, 2024
2a04ae1
Update userguide
daryltay415 Apr 12, 2024
0c649c7
Merge pull request #224 from daryltay415/master
EugeneChanJiajun Apr 12, 2024
afaac8a
Update Junit tests
EugeneChanJiajun Apr 12, 2024
19fa341
Merge pull request #225 from EugeneChanJiajun/master
ChinYanXu Apr 12, 2024
477e472
Merge branch 'master' of github.com:AY2324S2-CS2113-T12-4/tp
ChinYanXu Apr 12, 2024
4ddbac3
update javadoc
ChenKangg Apr 13, 2024
4c8b21a
update help command
ChenKangg Apr 13, 2024
5c3e699
add assertion, logger
ChenKangg Apr 13, 2024
acd67b1
update PPP
EugeneChanJiajun Apr 13, 2024
0c4d1db
fix docs
ChenKangg Apr 13, 2024
177791c
fix test error
ChenKangg Apr 13, 2024
8f32fd1
Merge pull request #226 from ChenKangg/master
daryltay415 Apr 13, 2024
641cb7f
Merge pull request #227 from EugeneChanJiajun/master
daryltay415 Apr 13, 2024
40c4d77
Update developer guide
daryltay415 Apr 13, 2024
f188890
Merge branch 'master' of github.com:AY2324S2-CS2113-T12-4/tp
ChinYanXu Apr 13, 2024
fe4b21c
Merge pull request #228 from daryltay415/master
ChinYanXu Apr 13, 2024
13fe4c3
Merge branch 'master' of github.com:AY2324S2-CS2113-T12-4/tp
ChinYanXu Apr 13, 2024
9cd8379
Git add META-INF
ChinYanXu Apr 13, 2024
6c80ab5
Finalise UG and DG
EugeneChanJiajun Apr 14, 2024
83dd6ff
Merge pull request #229 from EugeneChanJiajun/master
daryltay415 Apr 14, 2024
686eec4
Add javadocs
daryltay415 Apr 14, 2024
2a00711
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 14, 2024
4bfa388
Update PPP
EugeneChanJiajun Apr 14, 2024
02c8480
Merge pull request #230 from EugeneChanJiajun/master
daryltay415 Apr 14, 2024
b20066d
Update ppp
daryltay415 Apr 14, 2024
35d943f
Merge remote-tracking branch 'upstream/master'
daryltay415 Apr 14, 2024
ef6651c
update ppp
ChenKangg Apr 14, 2024
fb04fa8
Add Junit test for ui functions
ChinYanXu Apr 14, 2024
498d3b6
Fix bugs
daryltay415 Apr 14, 2024
b10bc73
Fix gradle
daryltay415 Apr 14, 2024
8bc1f41
Merge pull request #232 from ChenKangg/master
EugeneChanJiajun Apr 14, 2024
34e4f54
Update test Ui text
daryltay415 Apr 14, 2024
a63881f
Merge pull request #231 from daryltay415/master
daryltay415 Apr 14, 2024
b6e2615
Add jar file
daryltay415 Apr 14, 2024
771ed2a
Merge pull request #233 from daryltay415/master
EugeneChanJiajun Apr 14, 2024
17a8aed
Fix portfolio
daryltay415 Apr 14, 2024
f86bd6d
Merge pull request #234 from daryltay415/master
daryltay415 Apr 14, 2024
f697891
Update javadocs
ChinYanXu Apr 14, 2024
4788b25
update sequence diagram
ChenKangg Apr 14, 2024
cd09c70
Update UserGuide
ChinYanXu Apr 14, 2024
3ce1ead
Add more line coverage for travelactivitytypes
ChinYanXu Apr 14, 2024
683bb3c
Merge pull request #235 from ChenKangg/master
ChinYanXu Apr 14, 2024
bcd1ff7
Improve line coverage for Parser and CheckParameter class
ChinYanXu Apr 14, 2024
fafc681
Merge remote repo master to local repo master
ChinYanXu Apr 14, 2024
d7489c5
Update chinyanxu.md and fix JUnit bugs
ChinYanXu Apr 14, 2024
6470f7b
Update chinyanxu.md
ChinYanXu Apr 14, 2024
5c924d3
Merge pull request #236 from ChinYanXu/LineCoverageAndPPP
daryltay415 Apr 15, 2024
5536ba8
fixed totalexpense diagram
annnniexu Apr 15, 2024
31bc348
Merge pull request #237 from annnniexu/master
daryltay415 Apr 15, 2024
5795206
Fix developer guide sequence diagram
daryltay415 Apr 15, 2024
ccf62ac
Update user guide
daryltay415 Apr 15, 2024
f1796d3
Merge pull request #238 from daryltay415/master
EugeneChanJiajun Apr 15, 2024
6d1f6a0
Update save sequence diagram
EugeneChanJiajun Apr 15, 2024
e5c8e80
Merge branch 'master' of https://github.com/AY2324S2-CS2113-T12-4/tp
EugeneChanJiajun Apr 15, 2024
32d14b2
Merge pull request #239 from EugeneChanJiajun/master
daryltay415 Apr 15, 2024
844a6ea
Update code to follow java coding standards
daryltay415 Apr 15, 2024
a1e5e4f
Merge pull request #240 from daryltay415/master
EugeneChanJiajun Apr 15, 2024
db7febb
update PPP
EugeneChanJiajun Apr 15, 2024
7a45d8b
Merge pull request #241 from EugeneChanJiajun/master
EugeneChanJiajun Apr 15, 2024
a702047
Update PPP
EugeneChanJiajun Apr 15, 2024
d0161ec
Merge pull request #242 from EugeneChanJiajun/master
EugeneChanJiajun Apr 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ bin/

/text-ui-test/ACTUAL.TXT
text-ui-test/EXPECTED-UNIX.TXT
text-ui-test/ACTUAL-UNIX.TXT
3 changes: 3 additions & 0 deletions META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Manifest-Version: 1.0
Main-Class: seedu.duke.Duke

2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Duke project template
# Omnitravel

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this diagram a lot, very clear to see which classes implement and use which other classes. I like that you made this the first diagram in your TP as well, great work!

This is a project template for a greenfield Java project. It's named after the Java mascot _Duke_. Given below are instructions on how to use it.

Expand Down
5 changes: 3 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ test {
}

application {
mainClass.set("seedu.duke.Duke")
mainClass.set("seedu.omnitravel.omnitravel.OmniTravel")
}

shadowJar {
archiveBaseName.set("duke")
archiveBaseName.set("omnitravel")
archiveClassifier.set("")
}

Expand All @@ -43,4 +43,5 @@ checkstyle {

run{
standardInput = System.in
enableAssertions = true
}
14 changes: 7 additions & 7 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# About us
Display | Name | Github Profile | Portfolio
--------|:-------------------:|:---------------------------------------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | Eugene Chan Jiajun | [Github](https://github.com/EugeneChanJiajun) | [Portfolio](docs/team/eugenechanjiajun.md)
![](https://via.placeholder.com/100.png?text=Photo) | Daryl Tay | [Github](https://github.com/daryltay415) | [Portfolio](docs/team/daryltay415.md)
![](https://via.placeholder.com/100.png?text=Photo) | Annie Xu | [Github](https://github.com/annnniexu) | [Portfolio](docs/team/annnniexu.md)
![](https://via.placeholder.com/100.png?text=Photo) | Chin Yan Xu | [Github](https://github.com/ChinYanXu) | [Portfolio](docs/team/ChinYanXu.md)
![](https://via.placeholder.com/100.png?text=Photo) | Chen Kang | [Github](https://github.com/ChenKangg) | [Portfolio](docs/team/ChenKangg.md)

Display | Name | Github Profile | Portfolio
--------|:----:|:--------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
210 changes: 202 additions & 8 deletions docs/DeveloperGuide.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice diagrams, but the contents of the diagram within the alt box is quite repetitive. However it is still very clear what is happening which is more important.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the parser diagram, maybe you could split the line updateTravelActivity(travelActivityNumber, date, duration) into two lines so that the gray parts of the diagram to the right aren't so far away.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
is it possible to topologically sort this diagram so it is more clear? i.e. try to have all the arrows point in one direction or minimize crossing over

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good usage of code and markdown to illustrate what is happening. Overall quite a clear DG, but maybe more examples of how to use each feature and expected output would be helpful.

Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,115 @@
{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}

## Design & implementation

{Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}

### Overview
![Overview.png](Overview.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid the clinging dash-line arrows

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the AB3 DG, perhaps you could consider representing your overall architecture using components instead of individual classes. It might help your diagram look a little neater.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered the possibility of an incorrect representation of classes and methods in the sequence diagrams?

Given above is a overview of how each classes interact with one another in our software.

#[Proposed] Save feature

The save feature is facilitated by `FileSave`. It makes calls to the subclasses `Accommodation`, `Food` and `Landmark`
which are subclasses of the `TravelActivity` class to add each activity saved in the text file.

`addTravelActivity` is called everytime there is a valid-stored data in the text file that is read to upload the
activity back into the array list.

Step 1. When the user launches the app for the first time, it will check if the text file `omni.txt` exist.

Step 2. Once it is found that the text file exists, the `readFile()` method will call `loadFileContents(list)`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the AB3 format, maybe can consider adding intermediate charts to highlight the current state of the program at each step

image


Step 3. In the `loadFileContents(list)`, `Scanner(f)` would read the text file line by line and insert each line into

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to consider documenting the overall flow and how classes interact with each other instead of going into how methods are implemented?

the respective activity types and its contents with `/` as the delimiter.

The Sequence Diagram below shows how the save file feature is being implemented when the user re-enters the chatbot
after using the bye command.

![img.png](img.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the module website, class names should be on the top of the diagram, not on the bottom

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return arrows

Copy link

@YHWong20 YHWong20 Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Methods shouldn't be represented as instances (i.e., shouldn't have their own box at the top of the diagram). Perhaps combine them into a FileSave class instance instead? Then method calls can be represented using activation bars.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

list.addTravelActivity() method call should be made to the TravelActivityList, not to the Accomodation.

If you've created a new Accomodation object before calling list.addTravelActivity(), then highlight that in the diagram as well.

Likewise for the subsequent alt cases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top boxes should only contain classes rather than methods represented as instances, remember to add the ":" in front of the classes also (eg :Food)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do leave the bottom row empty (boxes should not exist on the bottom row), also do remember to put a "X" at the bottom of the line if the object is destroyed


The above sequence diagram shows how existing save text files will be reloaded back into Omnibots array list to act as
a form of save feature when the user exits the bot.


#[Proposed] Update feature

Proposed Implementation

The proposed update feature is mainly carried out by `TravelActivityList`. It stores objects with class `TravelActivity`in an array called `travelActivities`
and each `TravelActivity` class object contains a date and duration. The `TravelAcivityList` also contains the following method:
* `TravelActivityList#updateTravelActivity(travelActivityNumber, date, duration)`-- Updates the date and duration of the specified object of `TravelActivity` class type.

Step 1. When the user launches the app for the first time, there will be no objects of type `TravelActivity` in `travelActivities`.
Thus any attempts to call the command `update INDEX`
will result in an output telling the user that no travel activity can be found.

Step 2. After the user has added new travel activities into the `travelActivityList`, the user can execute
`update 1 /date 2020-12-20 /duration 2hours` command to update the date and duration of the first travel activity
in the travel activity list. The `update` command calls the `Parser#updateCommand(line, list)` which then calls the `TravelActivityList#updateTravelActivity(travelActivityNumber, date, duration)`
.

Step 3. The method will then find the travel activity with the corresponding travel activity number in the `travelActivities` and then set the new date and duration
of that travel activity.

The sequence diagram below shows how an update operation goes through the parser component:
![img_1.png](img_1.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first function update ..., you do not need to specify the real date and duration, just provide the function name

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colors are a little too dark, which makes it slightly unreadable. Consider making the colors lighter.


#[Proposed] Total Expense feature

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DG, this format is not correct. Make sure to edit it before the final DG is due!


Proposed Implementation

The proposed total expense feature is mainly carried out by `TravelActivityList`. It stores objects with class `TravelActivity`in an array called `travelActivities`
and each `TravelActivity` class object contains an expense associated with it. The `TravelAcivityList` also contains the following method:
* `TravelActivityList#totalExpense(type)`-- Returns the total expense of activities in the list with given type.

Step 1. When the user launched the app for the first time, there will be no objects of type `TravelActivity` in `travelActivities`.
Thus any attempts to call the command `total expense`
will result in an output of `0`.

Step 2. After the user has added new travel activities into the `travelActivityList`, the user can execute
`totalexpense [/type TYPE]` command to get the total expense for the activities in the list. The `total expense` command calls the `Parser#totalExpenseCommand(line, list)` which then calls the `TravelActivityList#totalExpense(type)`.

Step 3. The method will loop through each activity in `travelActivities` and add up all the expenses for the given type. If no type is provided, it will default to TravelActivity type.

![totalexpense.png](totalexpense.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly ensure that the notation used to denote the class instance is consistent with the module's conventions. (:OmniTravel instead of just OmniTravel).

Also, please ensure the descriptions in the [loop] and [opt] are correct as well. Loop conditions should be something like [while < travelList.size()] or somthing similar.


### Tag feature

The tag feature is implemented through the tagCommand method, which allows users to add tags to specific travel activities stored in the system.

The sequence diagram depicts the interaction between the user, the tagCommand method, the TravelActivityList instance, and the OmniException instance.

![TagSequenceDiagram.png](TagSequenceDiagram.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this diagram, for neatness purposes, should the first alt statement strictly be on the left side of the activation bar?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the process bar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add return arrows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on adopting a component-based architecture for diagrams to boost neatness, and ensuring the use of proper notation and conventions in sequence diagrams?


## Product scope
### Target user profile
* Needs to manage multiple travel plans
* Prefers typing to GUI

{Describe the target user profile}

### Value proposition

{Describe the value proposition: what problem does it solve?}
Tourists may have many plans during their holiday. Omnitravel aims to be a one-stop-shop for all travel plans.
Omnitravels stores the user's travel plans and enable them to quickly retrieve their travel plans using the search
functions.

## User Stories

|Version| As a ... | I want to ... | So that I can ...|
|--------|----------|---------------|------------------|
|v1.0|new user|see usage instructions|refer to them when I forget how to use the application|
|v2.0|user|find a to-do item by name|locate a to-do without having to go through the entire list|
| Version | As a ... | I want to ... | So that I can ... |
|---------|----------|----------------------------------------------------------------|-------------------------------------------------------------------------------------------|
| v1.0 | new user | see a list of my travel plans | refer and know what activities I have planned for the day |
| v1.0 | user | be able to label my destinations | identify the type of activity easily |
| v1.0 | user | be able to add and remove activities from my planner | easily make changes to my current activity list |
| v1.0 | user | be able to add tags or categories to my activities | organise them based on my preferences |
| v1.0 | user | be able to check and uncheck my travel activities | easily mark the activities that I have done if I do not follow the sequence of activities |
| v1.0 | user | have a help option | easily identify all the commands in the chatbot |
| v1.0 | user | be able to search for an activity already recorded in the list | easily retrieve exisiting plans and not have double inputs |
| v2.0 | user | maintain my expense records | make travel plans according to my budget |
| v2.0 | user | be able to see the travel durations | plan my activities more efficiently |
| v2.0 | user | be able to search for an activity based on its type or tag | find specific places in my list more efficiently |
| v2.0 | user | be able to delete a destination from my records | remove redundant records that I do not need |
| v2.0 | user | be able to edit and update existing plans | efficiently update exisiting plans without having to delete and add plans |
| v2.0 | user | have some form of QOL considerations like warning messages | know what are the errors that I have made in the inputs |


## Non-Functional Requirements

Expand All @@ -36,3 +126,107 @@
## Instructions for manual testing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good sample inputs and outputs here for testing!


{Give instructions on how to do a manual product testing e.g., how to load sample data to be used for testing}

- To add a general travel activity into the list

Example: `add visit Paris /date 2024-12-12 /duration 2 weeks`

Expected: A new general activity is added

- To add an accommodation activity into the list

Example: `accommodation hotel /date 2024-12-12 /duration one night`

Expected: A new accommodation activity type is added

- To add a food activity into the list

Example: `food prata /date 2024-12-12 /duration 1 hour`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explore ways to adhere more closely to coding standards and enhance code quality, such as adding : before classes?


Expected: A new food activity type is added

- To add a landmark activity into the list

Example: `landmark Eiffel Tower /date 2024-12-12 /duration 2 hour`

Expected: A new landmark activity type is added

- To delete an activity from the list

Example: `delete 1`

Expected: The general activity "visit Paris" should be deleted

- To update an existing activity date and duration in the list

Example: `update 1 /date 2024-12-13 /duration two nights`

Expected: The accommodation activity hotel would be on 13th Dec 2024 instead of 12th Dec 2024 and be for two nights instead of one

- To list out the current activity list

Example: `list`

Expected: The current activity list will be shown by the chatbot

- To find all travel plans with the same keyword

Example: `find rvrc`

Result:
____________________________________________________________
Here are what you are looking for:
1. Accommodation: rvrc :24 Dec 2024 :2 weeks
____________________________________________________________

- To find all travel plans with the same tag

Example: findtag delicacies

Result:
____________________________________________________________
Here are what you are looking for:
1. Food: Popia :1 Dec 2020 :1hour
2. Food: kfc :12 Dec 2024 :1 hour
____________________________________________________________

- To tag a travel plan

Example: tag 2 activity 1

Result:
____________________________________________________________
I have tagged this task:
Visit museum (activity 1)
____________________________________________________________

- To untag a travel plan

Example: untag 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do use " ' ' " to format your example inputs as per above (for consistency)


Result:
____________________________________________________________
Tag removed from the task:
Visit museum
____________________________________________________________

- To add an expense to a travel plan

Example: expense 1 $50

Result:
____________________________________________________________
I have added expense for this task:
Visit museum ($50)
____________________________________________________________

- To remove expense from a travel plan

Example: removeexpense 1

Result:
____________________________________________________________
Expense removed from the task:
Visit museum
____________________________________________________________

Binary file added docs/Overview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Duke
# Omnitravel

{Give product intro here}

Expand Down
Binary file added docs/TagSequenceDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading