[Guoyi] ip #109
[Guoyi] ip #109
Conversation
|
|
||
| while (true) { | ||
| input = scanner.nextLine(); | ||
| if (input.equals("bye")) { |
There was a problem hiding this comment.
Instead of using a long list of else ifs you could consider re factoring this into switch case form to improve readability. Just a suggestion!
|
|
||
| class Task { | ||
| protected String description; | ||
| protected boolean isDone; |
There was a problem hiding this comment.
Great job following the naming conventions for boolean variables!
| System.out.println("Now you have " + taskCount + " tasks in the list."); | ||
| } else if (input.startsWith("deadline ")) { | ||
| String[] parts = input.substring(9).split(" /by "); | ||
| tasks[taskCount] = new Deadline(parts[0], parts[1]); |
There was a problem hiding this comment.
You could consider adding some edge case catchers here to remind user the correct argument usage.
For example, if the user forgets to put /by you could print out something like expected argument containing /by
| } | ||
|
|
||
| class Event extends Task { | ||
| protected String from; |
There was a problem hiding this comment.
Great job keeping all variables in protected accessibility to improve security of your object's members!
| System.out.println("What can I do for you?"); | ||
|
|
||
| Scanner scanner = new Scanner(System.in); | ||
| Task[] tasks = new Task[100]; |
There was a problem hiding this comment.
You can avoid the use of 100 here which is a magic number.
No description provided.