[Ajay Shanker] iP #117
Open
[Ajay Shanker] iP #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Level 1: Echo Task
- Cleanup messages - Add Scanner to read user input
- Add print promt as arrow
- Task: Level-2 Add,List
- simple task that has description and done flag
- Remove names from previous tasks
- Task Level-3: Add support to mark & unmark
AaronZZ10
reviewed
Sep 5, 2024
src/main/java/Jarvis.java
Outdated
| printBreakLine(); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
the comment clearly states the purpose and parameters of the functions
src/main/java/Task.java
Outdated
| * | ||
| * @return status icon of the task | ||
| */ | ||
| public String getStatusIcon() { |
There was a problem hiding this comment.
well use of conditional operator to return status icon
src/main/java/Jarvis.java
Outdated
| System.out.print(" "); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
defining different methods of printing give your code great readability
src/main/java/Jarvis.java
Outdated
| * | ||
| * @param status | ||
| */ | ||
| private static void exit(int status) { |
There was a problem hiding this comment.
I like how you use system.exit to terminate the program
- Level 4 requirement
- Move non-related methods - Clean up switch case
- Remove commented code
- Update print list using stream
Cleanup UI
Update Docs readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.