Skip to content

Commit

Permalink
Update progress and add knowledge for EltonGohJH
Browse files Browse the repository at this point in the history
  • Loading branch information
EltonGohJH committed Mar 1, 2024
1 parent 953dfa2 commit 0fe0d49
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 4 deletions.
16 changes: 16 additions & 0 deletions students/EltonGohJH/knowledge.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,19 @@ The reason for this is that the developer of js-beautify has changed the way it
This caused a lot of tests to fail and I had to spend a lot of time debugging it.

Through this experience, I learned the importance of ensuring that changes are documented properly and correctly.

### gomock
I have learned to use GoMock, a mocking framework for Golang, which streamlines the creation of mock objects for unit testing. It helps with decoupling components, enabling the simulation of complex behaviors and interactions. I am surprised how easy it to use to mock complex behaviours.
Will definitely use it for Golang testing next time!

#### Resource used:
- [gomock docs](https://github.com/uber-go/mock)

### Yarn workspaces
Yarn Workspaces is a feature of Yarn that simplifies handling multiple packages within a single repository by enabling shared dependencies and centralized script management. I learnt Yarn Workspaces while setting up the repository for the Twenty project.
Overall, it is a good experience as I learnt more alternatives to Lerna and NPM workspaces.

#### Resource used:
- [Yarn workspaces docs](https://yarnpkg.com/features/workspaces)


28 changes: 24 additions & 4 deletions students/EltonGohJH/observations.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,31 @@
### Project: Foo
### Projects I have worked on

#### Mattermost
Mattermost is an open-source collaboration platform designed for secure communication throughout the entire software development lifecycle. It serves as a self-hostable alternative to Slack, offering similar functionalities with the added benefit of full control over hosting and management.

### Twenty
Twenty CRM is a modern, open-source Customer Relationship Management (CRM) platform. It serves as an self-hostable alternative to Salesforce.

Give an intro to the project here ...

### My Contributions

Give a description of your contributions, including links to relevant PRs
In the [mattermost PR (approved not merged yet)](https://github.com/mattermost/mattermost/pull/26278). I addressed this [issue](https://github.com/mattermost/mattermost/issues/25991) where the CLI command to list the teams uses a magic number of 9999. Utilizing such large magic numbers presents two problems: it restricts the ability to list more than 9999 teams and could result in a request that is too large. To solve this, I implemented pagination for the request, with each page containing 200 teams. Subsequently, I updated the test cases to reflect the new expected behavior.

In the [Twenty PR (merged)](https://github.com/twentyhq/twenty/pull/4198). I addressed an [issue](https://github.com/twentyhq/twenty/issues/4181) reported by a user concerning LinkedIn school URLs not parsing correctly. Upon investigating the issue on the frontend, I discovered that the existing regex was only configured to support company URLs. To resolve this, I updated the regex to also accommodate school URLs and conducted tests to ensure the fix was effective.


### My Learning Record

Give tools/technologies you learned here. Include resources you used, and a brief summary of the resource.
### gomock
I have learned to use GoMock, a mocking framework for Golang, which streamlines the creation of mock objects for unit testing. It helps with decoupling components, enabling the simulation of complex behaviors and interactions. I am surprised how easy it to use to mock complex behaviours.
Will definitely use it for Golang testing next time!

#### Resource used:
- [gomock docs](https://github.com/uber-go/mock)

### Yarn workspaces
Yarn Workspaces is a feature of Yarn that simplifies handling multiple packages within a single repository by enabling shared dependencies and centralized script management. I learnt Yarn Workspaces while setting up the repository for the Twenty project.
Overall, it is a good experience as I learnt more alternatives to Lerna and NPM workspaces.

#### Resource used:
- [Yarn workspaces docs](https://yarnpkg.com/features/workspaces)
15 changes: 15 additions & 0 deletions students/EltonGohJH/progress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
| Week | Achievements |
| ---- | ------------ |
| 1 | Help prepared idea & facilitated Saturday code sprint - MarkBind website making |
| 3 | Repo cleaning - Added tags to issues, added items to project road map, added summaries to issues, and cleaned up some issues. Examples: [Allow markbind serve to specify custom host #2382](https://github.com/MarkBind/markbind/issues/2382), [Optimize MarkBind for saving as PDF #2397](https://github.com/MarkBind/markbind/issues/2397), [UG: images appear in two places #2401](https://github.com/MarkBind/markbind/issues/2401) |
| 4 | Investigated: [UG: images appear in two places #2401](https://github.com/MarkBind/markbind/issues/2401) |
| 4 | Investigated and closed: [The collapsed page nav appears in the print view #2157](https://github.com/MarkBind/markbind/issues/2157) |
| 4, 5 | Reviewed: [MarkBind Template for Software Project Documentation #2400](https://github.com/MarkBind/markbind/pull/2400) |
| 5 | Reviewed: [Migrate stylelint to latest version #2292](https://github.com/MarkBind/markbind/pull/2425) |
| 5 | Discussed: [Use justified text formatting for tooltips #2420](https://github.com/MarkBind/markbind/issues/2420) |
| 5, 6 | Investigated and reviewed: [Fix external styles and script not hoisted #2414](https://github.com/MarkBind/markbind/pull/2414) |
| 6 | Reviewed: [Add line-numbers when wrapping is needed for printing #2431](https://github.com/MarkBind/markbind/pull/2431) |
| 6 | Investigated: [Tooltip artefact left over for annotation point #2432](https://github.com/MarkBind/markbind/issues/2432) |
| 6 | Reviewed and merged: [Disable pop over in a-point if there is no header and content passed by user #2436](https://github.com/MarkBind/markbind/pull/2436) |
| 6 | Investigated and fixed bug: [Utilize GitHub Actions to aid checking of commit message #2429](https://github.com/MarkBind/markbind/pull/2429) |
| 6 | Help fixed bug and merged: [Annotation content slot #2427](https://github.com/MarkBind/markbind/pull/2427) |

0 comments on commit 0fe0d49

Please sign in to comment.