Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project A][MacIntel][Kenneth Seet] Upgrade to Java 17 #17

Closed
wants to merge 4 commits into from

Conversation

damithc
Copy link

@damithc damithc commented Jul 4, 2024

This is based on #6 (by @itstrueitstrueitsrealitsreal) but using a Mac Intel computer to generate the JAR file.

JDK used: 17.0.11.fx-zulu
JAR file https://github.com/nus-oss/AB3-J17/releases/download/v0.3.0/MacIntel-KennethSeet.jar

@itstrueitstrueitsrealitsreal

Tested on Mac Silicon with JDK-FX 17.0.11.fx-zulu, and working.

Steps followed:

  1. Downloaded the JAR file from the PR.
  2. Switched to JDK-FX 17.0.11.fx-zulu using SDKMAN.
  3. Ran the JAR file using java -jar MacIntel-KennethSeet.jar.
  4. Performed a smoke test to verify basic functionality.

Results:

Everything is functioning as expected.

Screenshots:

Screenshot 2024-07-04 at 4 28 41 PM

@jyue487
Copy link

jyue487 commented Jul 5, 2024

Tested on Mac Silicon with JDK-FX 17.0.11.fx-zulu, and working.

Steps and results are identical to above.

@teoks0199
Copy link

Tested on Windows 11, and working.

Steps I followed:

  1. Downloaded the JAR file from the PR.
  2. Ran the JAR file using java -jar MacIntel-KennethSeet.jar.
  3. Performed a smoke test to check basic functionality.

image

@bennyLCK
Copy link

bennyLCK commented Jul 6, 2024

Smoke-Tested on Windows 11, using Oracle OpenJDK version 17.0.10 on Windows Powershell Terminal same as @teoks0199, basic commands were run to ensure full functionality of the application.

image

@baskargopinath
Copy link

Tested on Mac Silicon with JDK-FX 17.0.11.fx-zulu, and working.

Steps I followed:

Downloaded the JAR file from the PR.
Switched to JDK-FX 17.0.11.fx-zulu
Ran the JAR file using java -jar MacIntel-KennethSeet.jar.
Performed a smoke test to check basic functionality.
Results:
Everything is functioning as expected.

Screenshots:
image

@aureliony
Copy link

Tested on Ubuntu 22.04.4 LTS with zulu jdk 17.0.11. JAR is working fine.

Steps followed:
Downloaded the JAR file from the release.
Ran the JAR file using java -jar MacIntel-KennethSeet.jar.
Performed a smoke test to check basic functionality.

Results:
Everything is functioning as expected.

Screenshot from 2024-07-06 19-31-00

@gongg21
Copy link

gongg21 commented Jul 7, 2024

Tested on MacSilicon with JDK-FX 17.0.11.fx-zulu, and working fine.
Switched using SDKMAN, ensure it is 17.0.11.fx-zulu, note the .fx suffix.
Add/Delete command tested, works.
Help command tested, works.
Ran JAR file using java -jar <filename>.

Screenshot 2024-07-07 at 5 36 22 PM

@Carlintyj
Copy link

Tested on Mac (Silicon) using JDK-FX 17.0.11.fx-zulu and working.

Downloaded the JAR release, ran the jar file using java -jar MacIntel-KennethSeet.jar
Performed smoke test to check functionality.

Screenshot 2024-07-07 at 7 14 57 PM

@drustanyjt
Copy link

Tested on Linux (Ubuntu 22.04) using OpenJDK 17.0.11. Working.

Steps taken:

  1. Downloaded release
  2. Ran jar file using java -jar MacIntel-KennethSeet.jar
  3. Tested with basic commands

image

@brein62
Copy link

brein62 commented Jul 7, 2024

Tested on Windows 10 using JDK-FX 17.0.11.fx-zulu, and working.

Procedure

Ran the JAR file on PowerShell using java -jar MacIntel-KennethSeet.jar and performed a smoke test by running several commands to ensure basic functionality of the application:

  • add n/John p/12345678 e/[email protected] a/123 Example Road t/friends: works
  • find Roy: works
  • list: works
  • help: works
  • delete 3: works
  • clear: works

Results

The JAR functions as expected and all commands run during the smoke test work properly.

Screenshots

MacIntel-KennethSeet

@jedkohjk
Copy link

jedkohjk commented Jul 8, 2024

Tested on Windows 11 and working.

Steps I followed:

  1. Downloaded the JAR file from the release.
  2. Ran java -jar MacIntel-KennethSeet.jar.
  3. Tested some basic commands.

Screenshot

@damithc
Copy link
Author

damithc commented Jul 11, 2024

Closing, as the migration was done in fe805d8

@damithc damithc closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.