Revert TLS workaround after upgrading to JDK17 #19
Conversation
|
I followed what was changed in this PR and after testing, I can confirm that everything works as expected. There were no issues with GitHub Actions, and both Java CI and Codecov are functioning correctly on my Mac Silicon. |
|
works on m2 macbook pro, sonoma 14.5. @damithc, im wondering if we should test on macOS sequoia beta which will be released in september. so if mid-semester if some students upgrade to it we might be better prepared |
Yes @baskargopinath , in general, it's a good idea to test on upcoming version if feasible. |
|
@aureliony Can you add a detailed commit message (subject + body) too? Follow the guidelines given in https://se-education.org/guides/conventions/git.html |
The SSLProtocolException error when uploading test coverage information no longer occurs with JDK17, so the past workaround of disabling TLSv1.3 is no longer needed. Let's remove the workaround and re-enable TLSv1.3.
aureliony
force-pushed
the
revert-tls-workaround
branch
from
0602511
to
297f236
Compare
aureliony
changed the title
Closes #18