Update dependencies of the Java CI workflow #33
Conversation
|
@aureliony either send separate PRs for each independent change, or do all in this PR but have a separate commit for each independent change. |
aureliony
force-pushed
the
update-workflow
branch
from
d98994e
to
691a188
Compare
| with: | ||
| distribution: 'zulu' |
There was a problem hiding this comment.
For your information as to why Zulu has to be specified here for setup-java@v4:
When upgrading actions/setup-java@v1 to actions/setup-java@v4, from v2 onwards, the distribution parameter here is mandatory. Since the original CI workflow version (v1) did not specify a distribution parameter, it used the zulu distribution by default (https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.md).
There was a problem hiding this comment.
Thanks for this info, @brein62
@aureliony Perhaps mention this in the relevant commit message? Also, your commit message body is slightly wider than permitted by our Git convention.
There was a problem hiding this comment.
Thanks for the additional info. Commit bodies have been updated and wrapped at 72 chars.
The current version (v1) of Gradle Wrapper Validation Action is outdated and may stop working in the future. Let's update the workflow dependency, and use the format as recommended in https://github.com/gradle/wrapper-validation-action/blob/main/README.md.
The current version (v1) of the setup-java action is outdated, and may stop working in the future. As newer versions of the action require the 'distribution' field, 'zulu' is specified, which is the default used in v1. Let's update the workflow dependency, and use the format as recommended in https://github.com/actions/setup-java/blob/main/README.md.
The current version (v3) of the codecov action had previously stopped working (nus-cs2103-AY2324S2/forum#729), and may stop working again in the future. Let's update the codecov action to the latest version (v4) to minimize the chance of it breaking, and use the format as recommended in https://github.com/codecov/codecov-action/blob/main/README.md.
aureliony
force-pushed
the
update-workflow
branch
from
691a188
to
a11bbfd
Compare
Closes #26.