Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W3.9][T13-3]Amirul Maricar #10

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[W3.9][T13-3]Amirul Maricar #10

wants to merge 8 commits into from

Conversation

amirulmaricar
Copy link

@amirulmaricar amirulmaricar commented Sep 10, 2018 •
edited
Loading

What this PR do?

Modified to use hash map with enumerated person's details for the address book. Fixes some import statements and implemented case-insensitive find command.

Also, PR from develop branch instead of previously created find branch.

Where should the reviewer start?

Anywhere from the list of all persons in address book

How should this be manually tested?

When using find pass in a mixture of upper and lower case for command arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okkhoy okkhoy Awaiting requested review from okkhoy

Assignees

@nishantbudhdev nishantbudhdev

Labels
team.3 tutorial.T13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amirulmaricar @nishantbudhdev @nus-se-pr-bot