[W6.2b][F09-4] Andrew Ong Ming En #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mutated in logic.java
fanyiii
reviewed
Sep 23, 2018
| @@ -70,4 +70,8 @@ public int getTargetIndex() { | |||
| public void setTargetIndex(int targetIndex) { | |||
| this.targetIndex = targetIndex; | |||
| } | |||
|
|
|||
| public boolean isMutating() { | |||
There was a problem hiding this comment.
alternatively, this could also be specified as abstract, since all commands have their own implementation based on their behavior
| @@ -85,7 +85,10 @@ public CommandResult execute(String userCommandText) throws Exception { | |||
| private CommandResult execute(Command command) throws Exception { | |||
| command.setData(addressBook, lastShownList); | |||
| CommandResult result = command.execute(); | |||
| storage.save(addressBook); | |||
|
|
|||
There was a problem hiding this comment.
Since now the storage is only updated when a command is mutation, the header comment should be updated accordingly to reflect the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added isMutating boolean to all command classes
storage.save only if command is mutated in logic.java