[W6.2b][F09-3] Sarah Taaher Bonna #134
Conversation
| } | ||
| // public CommandResult execute(){ | ||
| // throw new UnsupportedOperationException("This method should be implement in child classes"); | ||
| // } |
There was a problem hiding this comment.
Don't leave commented out code. Just go ahead and delete unused code, we can recover any deleted code later.
| @@ -70,4 +73,10 @@ public int getTargetIndex() { | |||
| public void setTargetIndex(int targetIndex) { | |||
| this.targetIndex = targetIndex; | |||
| } | |||
|
|
|||
| public boolean isMutating(String userCommandText) { | |||
There was a problem hiding this comment.
This method should have a header comment. If not, users of the method as well as those who overrides method will not know how exactly the method behaves.
|
|
||
| public boolean isMutating(String userCommandText) { | ||
| this.userCommandText = userCommandText; | ||
| if(userCommandText == "add" || userCommandText == "delete") return true; |
There was a problem hiding this comment.
Try to use overriding in subclasses to specify the different behavior of this method instead (it will not need to take in any argument), so that when you add any new command, you won't have to change parts outside of that class
| @@ -82,10 +82,10 @@ public CommandResult execute(String userCommandText) throws Exception { | |||
| * @return result of the command | |||
| * @throws Exception if there was any problem during command execution. | |||
| */ | |||
| private CommandResult execute(Command command) throws Exception { | |||
| private CommandResult execute(Command command, String userCommandText) throws Exception { | |||
There was a problem hiding this comment.
Remember to update the header comments accordingly
| } catch (UniquePersonList.DuplicatePersonException dpe) { | ||
| return new CommandResult(MESSAGE_DUPLICATE_PERSON); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isMutating(String userCommandText) { |
There was a problem hiding this comment.
There is actually no polymorphism as the subclass simply calls the super class method. A better way to specify the behaviors of different commands would be to remove the default implementation in super class, and having each sub class returning True/False.
No description provided.