Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W6.2f][F09-4] Rachel Lee #136

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[W6.2f][F09-4] Rachel Lee #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ee9866
Update DeveloperGuide.adoc
leerachel Aug 31, 2018
4a18d6b
Merge remote-tracking branch 'upstream/master'
leerachel Sep 9, 2018
2a861d6
Used Polymorphism by adding isMutating() in Command Class
leerachel Sep 20, 2018
38ec212
Revert "Used Polymorphism by adding isMutating() in Command Class"
leerachel Sep 20, 2018
e92a1c2
Made Command Class's execute() an abstract method
leerachel Sep 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/DeveloperGuide.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un
|===========================================================================================================================================
|Priority |As a ... |I want to ... |So that I can...
|`* * *` |new user |see usage instructions |refer to instructions when I forget how to use the App
|`* * *` |user |add a new person |
|`* * *` |user |add a new person | add details of people
|`* * *` |user |delete a person |remove entries that I no longer need
|`* * *` |user |find a person by name |locate details of persons without having to go through the entire list
|`* * *` |user |edit details of a person |update details or make small changes without having to remove and re-add the person
|`* *` |user |hide <<private-contact-detail, private contact details>> by default |minimize chance of someone else seeing them by accident
|`*` |user with many persons in the address book |sort persons by name |locate a person easily
|===========================================================================================================================================
Expand Down
4 changes: 1 addition & 3 deletions src/seedu/addressbook/commands/Command.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ public static String getMessageForPersonListShownSummary(List<? extends ReadOnly
/**
* Executes the command and returns the result.
*/
public CommandResult execute(){
throw new UnsupportedOperationException("This method should be implement in child classes");
}
public abstract CommandResult execute();

//Note: it is better to make the execute() method abstract, by replacing the above method with the line below:
//public abstract CommandResult execute();
Expand Down