[W6.2i][F09-4] Rachel Lee #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added user story for "edit" function
This reverts commit 2a861d6.
fanyiii
reviewed
Sep 24, 2018
| @@ -8,7 +8,7 @@ | |||
| * A read-only immutable interface for a Person in the addressbook. | |||
| * Implementations should guarantee: details are present and not null, field values are validated. | |||
| */ | |||
| public interface ReadOnlyPerson { | |||
| public interface ReadOnlyPerson extends Printable{ | |||
There was a problem hiding this comment.
since this interface is implemented by the Person class, the new methods also need to be implemented in that class. Alternative is to have the Person class implementing Printable instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not done, unsure of how to implement printable interface.