[W7.8][W12-3]Ler Wei Sheng #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review |
CT15
approved these changes
Oct 5, 2018
| @Override | ||
| public void changed(ObservableValue<? extends String> observable, | ||
| String oldValue, String newValue) { | ||
| // System.out.println(newValue); |
There was a problem hiding this comment.
Can remove this instead of just comment out.
CT15
reviewed
Oct 5, 2018
| @@ -6,6 +6,8 @@ | |||
| import seedu.addressbook.data.person.UniquePersonList.DuplicatePersonException; | |||
| import seedu.addressbook.data.person.UniquePersonList.PersonNotFoundException; | |||
|
|
|||
| import java.util.Set; | |||
|
|
|||
| @@ -55,4 +55,11 @@ public int hashCode() { | |||
| public boolean isPrivate() { | |||
| return isPrivate; | |||
| } | |||
|
|
|||
| @Override | |||
| public String getPrintableString (Printable... printables) { | |||
There was a problem hiding this comment.
What is the purpose of taking in printables argument?
| @@ -58,4 +58,11 @@ public int hashCode() { | |||
| public boolean isPrivate() { | |||
| return isPrivate; | |||
| } | |||
|
|
|||
| @Override | |||
| public String getPrintableString (Printable... printables) { | |||
| @@ -61,4 +61,9 @@ public int hashCode() { | |||
| return fullName.hashCode(); | |||
| } | |||
|
|
|||
| @Override | |||
| public String getPrintableString (Printable... printables) { | |||
|
|
||
|
|
||
| @Override | ||
| public String getPrintableString (Printable... printables) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.