[W6.2i][T16-2] Ang Jie Liang #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephlewyh
reviewed
Sep 30, 2018
|
|
||
| @Override | ||
| public String getPrintableString(){ | ||
| return String.format(MESSAGE_EMAIL, value); |
There was a problem hiding this comment.
Good. You may also consider formatting strings with Formatter, from java.util.Formatter.
| final StringBuilder builder = new StringBuilder(); | ||
|
|
||
| for (Printable printable : printables) { | ||
| builder.append(printable.getPrintableString()); |
There was a problem hiding this comment.
Good job in invoking the new implementedgetPrintableString() method. On the flip-side, if you don't use it, there is not much pointing implementing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.