Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W7.8a][T09-1]Sean Tan Rui Xiang #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trufflepirate
Copy link

added command that lists all persons in address book but sorted alphabetically by name.

This command lists all persons in address book but sorted alphabetically by name.
@nus-se-pr-bot
Copy link

Hi @trufflepirate, your pull request title is invalid.

For PR sent to satisfy a learning outcome, the PR name should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-2] means Wednesday 2pm (14 hrs), Team 2).
E.g. If you are in tutorial W09 (i.e. Wednesday 9am), team 1, and is submitting a PR for LO W2.2b, the PR title would be [W2.2b][W09-1] James Yong. Note that your tutorial IDs are different from those shown in CORS/IVLE.

For team PR, the PR name should be in the format of [Team ID] Product Name (e.g. [T09-2] Contact List Pro).

Please follow the above format strictly and edit your title for reprocessing.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR.

@trufflepirate trufflepirate changed the title [LO-3KLoC][T09-1]Sean Tan Rui Xiang [3KLoC][T09-1]Sean Tan Rui Xiang Oct 22, 2018
@nus-se-pr-bot
Copy link

Hi @trufflepirate, your pull request title is invalid.

For PR sent to satisfy a learning outcome, the PR name should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-2] means Wednesday 2pm (14 hrs), Team 2).
E.g. If you are in tutorial W09 (i.e. Wednesday 9am), team 1, and is submitting a PR for LO W2.2b, the PR title would be [W2.2b][W09-1] James Yong. Note that your tutorial IDs are different from those shown in CORS/IVLE.

For team PR, the PR name should be in the format of [Team ID] Product Name (e.g. [T09-2] Contact List Pro).

Please follow the above format strictly and edit your title for reprocessing.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR.

@trufflepirate trufflepirate changed the title [3KLoC][T09-1]Sean Tan Rui Xiang [W7.8a][T09-1]Sean Tan Rui Xiang Oct 22, 2018
@trufflepirate
Copy link
Author

trufflepirate commented Oct 22, 2018

Okay, according to the ivle announcement and the github LO pages for AB3, theres AB3 enhancement, but i can't for the life of me find the LO code. :/ So the LO tag is wrong, but this probably gets the bot's attention and adds a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants