forked from se-edu/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated User Story #33
Open
OscarZeng
wants to merge
145
commits into
nusCS2113-AY1819S1:master
Choose a base branch
from
OscarZeng:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change use cases
Removed implementation of parsing phone. Added new implementation to parse dates. - Dates must be in the format: dd-mm-yyyy - Modified all XML files for test cases - Modified all JUnit tests and ensured they pass
Added the new implementation for parsing expenses. - Defined new format for expenses - Modified XML for test case - Ensured Junit tests pass
Added new implementation for parsing income - New format for income, follows that of expense - Modified XML files for all email parameters - Ensured all Junit tests pass - Ensured all function type signatures, variable names and comments are coherent with the new classes
Added new implementation for parsing income - New format for income, follows that of expense - Modified XML files for all email parameters - Ensured all Junit tests pass - Ensured all function type signatures, variable names and comments are coherent with the new classes
…book-level4 into MorphAddressBook # Conflicts: # src/main/java/seedu/address/model/record/Income.java
…Book Revised basic morph in FinancialPlanner
Changed the way Income and Expense parse the strings Junit tests not complete
Junit tests not changed
Revised basic morph in FinancialPlan
…tion Modification to add function
…y list. ListCommand also returns the default predicate if no arg is defined. Defined equals behaviour for all newly made classes
…4/AboutUs Updated the AboutUs.adoc
All conflicts have been resolved and the LimitCommand& LimitCommandParser works well.
…nancialPlannerSystemTest
…n text box of DetailedCard is clicked
…atters Implemented a UI panel that displays more details when card is clicked
…into Oscar_SimpleLimit
…for both date start and date end
…rsion), is working!!(with many check style errors tho)
…an only be double number without sign in front. && The same amount of money will not regard as limit exceeded.
Ftywan
referenced
this pull request
in Ftywan/PERRIER
Oct 10, 2018
Changed implementation of Machine Status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.