-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse Prerequisite Tree #3263
base: master
Are you sure you want to change the base?
Conversation
@sciffany is attempting to deploy a commit to the NUSMods Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). nusmods-export – ./export🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/9raPkAujhUL7emGntC45M9QxoBaL nusmods-website – ./website🔍 Inspect: https://vercel.com/nusmodifications/nusmods-website/6FP3WtgvDP4CAnZC3jqZ45aqfkUh |
…mods into reverse-prereq-tree
for ref: alternate implementation in #3291 but we'll review this PR first @taneliang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I really like the renaming, it definitely makes it easier to understand!
@@ -4,6 +4,7 @@ $connector-size: 0.75rem; | |||
|
|||
.container { | |||
display: flex; | |||
flex-direction: row-reverse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For accessibility reasons, we should not use row-reverse here.
I know it's a lot more work to flip the dom order, but I think it's worth it to prevent confusion for our fellow students with visual disabilities.
Context
Solves #3202
Implementation
Use CSS to reverse formatting of Prerequisite Tree
Result
Before
After
Other Information
I renamed some variables from
prereq
todepedent
, as they are mostly used to refer to the dependent modules (e.g. CS3247 above)