-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten timetable share URL #3367
base: master
Are you sure you want to change the base?
Conversation
@winphong is attempting to deploy a commit to the NUSMods Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). nusmods-export – ./export🔍 Inspect: https://vercel.com/nusmodifications/nusmods-export/AVdmcWRd2grXypgL8H8fWGEuVKJe |
Codecov Report
@@ Coverage Diff @@
## master #3367 +/- ##
==========================================
+ Coverage 53.08% 53.27% +0.18%
==========================================
Files 270 270
Lines 5745 5757 +12
Branches 1327 1332 +5
==========================================
+ Hits 3050 3067 +17
+ Misses 2695 2690 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work, and apologies for the delay. The code and tests look good to me. @chrisgzf I'll leave the merging to you? We should also open a task to bring our url shorterner back up.
Context
This PR fixes #2057 where timetable share url is not shortened
Implementation
Loading spinner while url is being shortened
Display show original URL button when URL is shortened
NOTE: Used a separate url shortener service to mock url shortening behaviour
Display shorten URL button when URL is full
URL shortening errored
Other Information
👋🏻 my first time contributing to a project, implemented the solution based on my personal experience on user experience, open to suggestion if there's a better UX. Tried my best but not too familiar with UI test so do let me know if there's something that I can improve on. Thanks 🙏🏻