Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace messenger with telegram #3802

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mug1wara26
Copy link
Contributor

Context

Messenger group is no longer used, adds a telegram button to the contribute page and replaces all other mentions of messenger with telegram.
Issue: #3794

Implementation

Replace the messenger button with a telegram button. The background color uses the telegram background color and the icon uses the Send icon from react-feather

image

Other Information

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:32am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:32am

Copy link

vercel bot commented Aug 21, 2024

@mug1wara26 is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.59%. Comparing base (2d4743d) to head (092c73c).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
website/src/views/settings/BetaToggle.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
+ Coverage   53.87%   54.59%   +0.71%     
==========================================
  Files         274      274              
  Lines        6032     6052      +20     
  Branches     1449     1445       -4     
==========================================
+ Hits         3250     3304      +54     
+ Misses       2782     2748      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwliew
Copy link
Member

zwliew commented Aug 27, 2024

Hi thanks for this. However, I recently merged another commit that also adds Telegram buttons in some places. It would still be good to remove the FB messenger buttons though, so could you rebase your commit on top of the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants