Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update existing and add new tests for migration v2 #754

Merged
merged 24 commits into from
Sep 15, 2023
Merged

update existing and add new tests for migration v2 #754

merged 24 commits into from
Sep 15, 2023

Conversation

w-henderson
Copy link
Contributor

@w-henderson w-henderson commented Jul 28, 2023 •
edited
Loading

This commit introduces additional testing for migration v2, as well as updating/removing the old tests for migration v1. Additionally, a number of tests are moved from unit-tests.c to the Python tests.

@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from d2266ed to 5d92583 Compare July 31, 2023 14:46
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch 2 times, most recently from adc9cbb to 6c62dae Compare July 31, 2023 15:33
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 5d92583 to 4e98468 Compare August 1, 2023 09:23
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch from 6c62dae to a70faee Compare August 1, 2023 09:27
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 4e98468 to 90c1f69 Compare August 1, 2023 09:40
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch from a70faee to 4b58077 Compare August 1, 2023 09:40
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 90c1f69 to 6c812cb Compare August 2, 2023 11:43
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch from db6e931 to 495a5e3 Compare August 2, 2023 11:43
@w-henderson w-henderson mentioned this pull request Aug 2, 2023
Closed
5 tasks
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 6c812cb to 5b70ec5 Compare August 2, 2023 14:06
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch 2 times, most recently from 8e7df74 to 2d6ff03 Compare August 2, 2023 14:21
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 49c8ad4 to 9788b4c Compare August 4, 2023 11:23
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch 2 times, most recently from 2c86cc8 to e9ac281 Compare August 4, 2023 13:03
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 52f1b50 to 716ebaf Compare August 7, 2023 15:25
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch 3 times, most recently from 03b6625 to a39b8e3 Compare August 7, 2023 15:35
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 716ebaf to 9ca54e3 Compare August 9, 2023 15:58
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch from a39b8e3 to 9992506 Compare August 9, 2023 15:58
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 9ca54e3 to 16c1ed0 Compare August 10, 2023 09:01
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch from 9992506 to 91c319f Compare August 10, 2023 09:01
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from 16c1ed0 to 5c0792a Compare August 10, 2023 14:09
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch 2 times, most recently from efa8edf to f967937 Compare August 11, 2023 09:27
jlevon
jlevon reviewed Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@jlevon jlevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all this testing!
As I mention, if we can get the necessary test done in python code, let's drop the unit-test.c code, no need to test things twice, and I don't think a lot of that code is of much value.

test/py/test_request_errors.py Show resolved Hide resolved
test/py/test_migration.py Outdated Show resolved Hide resolved
test/py/test_dirty_pages.py Show resolved Hide resolved
test/unit-tests.c Outdated Show resolved Hide resolved
test/unit-tests.c Outdated Show resolved Hide resolved
test/unit-tests.c Outdated Show resolved Hide resolved
test/unit-tests.c Outdated Show resolved Hide resolved
test/unit-tests.c Outdated Show resolved Hide resolved
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-samples branch from abab1f2 to a11c1d1 Compare August 16, 2023 15:13
@w-henderson w-henderson force-pushed the w-henderson/migration-v2-tests branch from f967937 to 5e950e4 Compare August 16, 2023 15:13
@jlevon jlevon force-pushed the w-henderson/migration-v2-samples branch from f6562c1 to 2101ec4 Compare September 15, 2023 12:04
Base automatically changed from w-henderson/migration-v2-samples to master-migv2 September 15, 2023 12:05
@w-henderson @jlevon
test: update existing tests
76b0d84 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: reintroduce migration unit tests for v2
f859512 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add migration state sequence test
d4a01e1 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add tests for handle_mig_data_read
a43e509 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add tests for handle_mig_data_write
014f0b4 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add test for starting in RESUMING state
a20c96c 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add tests for dirty page logging
fb04887 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: fix memory leak in unit tests
d636a4d 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
fix: conflict with kernel definitions in tests
e843750 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add tests for logging specific pages
d3020a4 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
fix: memory leak in dirty page tracking tests
161771f 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add tests for migration FSM paths
dc85c28 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add test for nonexistent state
0db1c37 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
fix: fixes for changes from John's core review
ffbd9f8 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
refactor: move a number of tests from C to Python
38fce72 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add missing tests for different dirty page sizes
13affff 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: improve test coverage
962e613 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
fix: argsz semantics in tests
e3fcfa4 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
test: add more tests for bad argsz
631ac2a 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
fix: authors of test_migration.py
9ed381b 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
respond to more of Thanos's comments
37a77a8 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
refactor migration tests and small test fixes
e9127e0 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
refactor bad python
f567bb8 
Signed-off-by: William Henderson <[email protected]>
@w-henderson @jlevon
refactor migration transition test
e87e6a3 
Signed-off-by: William Henderson <[email protected]>
@jlevon jlevon force-pushed the w-henderson/migration-v2-tests branch from 9770270 to e87e6a3 Compare September 15, 2023 12:05
@jlevon jlevon merged commit e746e82 into master-migv2 Sep 15, 2023
5 checks passed
@jlevon jlevon deleted the w-henderson/migration-v2-tests branch September 15, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlevon jlevon jlevon left review comments

@tmakatos tmakatos tmakatos approved these changes

Assignees
No one assigned
Labels
migration-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@w-henderson @tmakatos @jlevon