Adding minor fixes for ansible lint checks (#542)

* Adding minor fixes for ansible lint checks * Adding new line at the end of files for ansible lint fixes * Adding more lint fixes
nutanix · Dec 16, 2024 · 2be9a6f · 2be9a6f
1 parent 013c7b4
commit 2be9a6f
Show file tree

Hide file tree

Showing 14 changed files with 47 additions and 42 deletions.
diff --git a/tests/integration/targets/ntnx_clusters_and_hosts_v2/tasks/cluster_crud.yml b/tests/integration/targets/ntnx_clusters_and_hosts_v2/tasks/cluster_crud.yml
@@ -503,7 +503,9 @@
       - '"{{ clusters[0].config.cluster_functions[0] }}" in "{{result.response.config.cluster_function}}"'
       - result.response.config.redundancy_factor == clusters[0].config.redundancy_factor_cluster_crud
       - result.response.config.cluster_arch == "{{ clusters[0].config.cluster_arch }}"
-      - result.response.config.fault_tolerance_state.domain_awareness_level == "{{ clusters[0].config.fault_tolerance_state.domain_awareness_level_cluster_crud }}"
+      - >
+        result.response.config.fault_tolerance_state.domain_awareness_level ==
+        "{{ clusters[0].config.fault_tolerance_state.domain_awareness_level_cluster_crud }}"
     fail_msg: Failed verifying cluster creation
     success_msg: Cluster creation passed successfully
 
@@ -677,7 +679,9 @@
       - '"{{ clusters[0].config.cluster_functions[0] }}" in "{{result.response.config.cluster_function}}"'
       - result.response.config.redundancy_factor == clusters[0].config.redundancy_factor_cluster_crud
       - result.response.config.cluster_arch == "{{ clusters[0].config.cluster_arch }}"
-      - result.response.config.fault_tolerance_state.domain_awareness_level == "{{ clusters[0].config.fault_tolerance_state.domain_awareness_level_cluster_crud }}"
+      - >
+        result.response.config.fault_tolerance_state.domain_awareness_level ==
+        "{{ clusters[0].config.fault_tolerance_state.domain_awareness_level_cluster_crud }}"
       - result.response.network.external_address.ipv4.value == "{{ clusters[0].network.virtual_ip }}"
       - unique_ntp_servers | length == 4
       - unique_dns_servers | length == 2

diff --git a/tests/integration/targets/ntnx_clusters_nodes_v2/tasks/add_remove_nodes.yml b/tests/integration/targets/ntnx_clusters_nodes_v2/tasks/add_remove_nodes.yml
@@ -485,7 +485,9 @@
       - result.response.config.cluster_function[0] == "{{ clusters[0].config.cluster_functions[0] }}"
       - result.response.config.redundancy_factor == clusters[0].config.redundancy_factor_cluster_expanding
       - result.response.config.cluster_arch == "{{ clusters[0].config.cluster_arch }}"
-      - result.response.config.fault_tolerance_state.domain_awareness_level == "{{ clusters[0].config.fault_tolerance_state.domain_awareness_level_cluster_expanding }}"
+      - >
+        result.response.config.fault_tolerance_state.domain_awareness_level ==
+        "{{ clusters[0].config.fault_tolerance_state.domain_awareness_level_cluster_expanding }}"
     fail_msg: Failed verifying cluster creation
     success_msg: Cluster creation passed successfully
 

diff --git a/...tegration/targets/ntnx_foundation_central_imaged_clusters_info/tasks/get_cluster_info.yml b/...tegration/targets/ntnx_foundation_central_imaged_clusters_info/tasks/get_cluster_info.yml
@@ -52,7 +52,7 @@
     success_msg: "succes: get imaged cluster using custom filter sucessfully"
 
 # still offset and length
-# - debug:
+# - ansible.builtin.debug:
 #     var: clusters.response
 
 # - name: get imaged cluster using image_cluster_uuid
@@ -62,5 +62,5 @@
 #     length: 20
 #   register: result
 #   ignore_errors: true
-# - debug:
+# - ansible.builtin.debug:
 #     var:  result.response.imaged_clusters|length
diff --git a/tests/integration/targets/ntnx_foundation_discover_nodes_info/tasks/discover_nodes.yml b/tests/integration/targets/ntnx_foundation_discover_nodes_info/tasks/discover_nodes.yml
@@ -39,7 +39,7 @@
 #   register: result
 
 # - name: Creation Status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.blocks is defined
 #       - result.failed==false

diff --git a/tests/integration/targets/ntnx_ndb_profiles/tasks/network_profile.yml b/tests/integration/targets/ntnx_ndb_profiles/tasks/network_profile.yml
@@ -116,7 +116,7 @@
 #   ignore_errors: true
 
 # - name: check listing status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.failed == false
@@ -133,7 +133,7 @@
 #     fail_msg: "Fail: unable to verify create of multiple cluster network profile "
 #     success_msg: "Pass:  verify create of multiple cluster network profile finished sucessfully"
 
-# - set_fact:
+# - ansible.builtin.set_fact:
 #     todelete: "{{ todelete + [  result.profile_uuid ] }}"
 ################################################################
 # - name: update the profile for multiple cluster by  subnets, publish
@@ -156,7 +156,7 @@
 #   ignore_errors: true
 
 # - name: check listing status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.failed == false

diff --git a/tests/integration/targets/ntnx_ndb_vlans/tasks/create_vlans.yml b/tests/integration/targets/ntnx_ndb_vlans/tasks/create_vlans.yml
@@ -338,10 +338,10 @@
 #        - "{{st_vlan.vlans_subnet1[1]}}"
 #   register: result
 #   ignore_errors: true
-# - debug:
+# - ansible.builtin.debug:
 #    var: result
 # - name: check listing status
-#   assert:
+#   ansible.builtin.assert:
 #    that:
 #      - result.response is defined
 #      - result.changed == true
@@ -354,7 +354,7 @@
 #    fail_msg: "fail: Unable to create ndb_stretched vlan"
 #    success_msg: "pass: create ndb_stretched vlan finished successfully"
 
-# - set_fact:
+# - ansible.builtin.set_fact:
 #     todelete: "{{ todelete + [  result.vlan_uuid ] }}"
 
 # ################################################################
@@ -369,10 +369,10 @@
 #        - "{{st_vlan.vlans_subnet2[1]}}"
 #   register: result
 #   ignore_errors: true
-# - debug:
+# - ansible.builtin.debug:
 #    var: result
 # - name: check listing status
-#   assert:
+#   ansible.builtin.assert:
 #    that:
 #      - result.response is defined
 #      - result.changed == true
@@ -394,10 +394,10 @@
 #      subnet_mask: "{{st_vlan.subnet_mask}}"
 #   register: result
 #   ignore_errors: true
-# - debug:
+# - ansible.builtin.debug:
 #     var: result
 # - name: check listing status
-#   assert:
+#   ansible.builtin.assert:
 #    that:
 #      - result.response is defined
 #      - result.changed == true

diff --git a/tests/integration/targets/ntnx_protection_rules/tasks/protection_rules.yml b/tests/integration/targets/ntnx_protection_rules/tasks/protection_rules.yml
@@ -269,7 +269,7 @@
     fail_msg: "Unable to update protection rule with asynchronous schedule"
     success_msg: "Protection policy with with asynchronous schedule updated successfully"
 
-##################################################################################################################################################################
+####################################################################################
 
 - name: Idempotency Check
   ntnx_protection_rules:
@@ -323,7 +323,7 @@
     fail_msg: "Idempotency check failed"
     success_msg: "Idempotency check passed"
 
-##################################################################################################################################################################
+####################################################################################
 
 - name: Check Mode while update
   check_mode: true

diff --git a/tests/integration/targets/ntnx_static_routes/tasks/create.yml b/tests/integration/targets/ntnx_static_routes/tasks/create.yml
@@ -42,23 +42,21 @@
     success_msg: "Succes: static routes updated successfully"
 
 - name: Wait 1 minute for static routes to be become active
-  pause:
+  ansible.builtin.pause:
     seconds: 60
 
-- name: get all static routes
+- name: Get all static routes
   ntnx_static_routes_info:
     vpc_uuid: "{{ vpc.uuid }}"
   register: result
 
-- set_fact:
+- name: Set destination variables
+  ansible.builtin.set_fact:
     d1: "{{ result.response.status.resources.static_routes_list[0].destination }}"
     d2: "{{ result.response.status.resources.static_routes_list[1].destination }}"
 
-- debug:
-    msg: "{{ result }}"
-
-- name: check info module response
-  assert:
+- name: Check info module response
+  ansible.builtin.assert:
     that:
       - result.response is defined
       - result.changed == false
@@ -115,19 +113,20 @@
     success_msg: "Static routes overriden successfully"
 
 - name: Wait 1 minute for static routes to be become active
-  pause:
+  ansible.builtin.pause:
     seconds: 60
 
-- name: get all static routes
+- name: Get all static routes
   ntnx_static_routes_info:
     vpc_uuid: "{{ vpc.uuid }}"
   register: result
 
-- set_fact:
+- name: Set destination variable
+  ansible.builtin.set_fact:
     d1: "{{ result.response.status.resources.static_routes_list[0].destination }}"
 
-- name: check info module response
-  assert:
+- name: Check info module response
+  ansible.builtin.assert:
     that:
       - result.response is defined
       - result.changed == false

diff --git a/tests/integration/targets/ntnx_static_routes_info/tasks/info.yml b/tests/integration/targets/ntnx_static_routes_info/tasks/info.yml
@@ -32,7 +32,7 @@
 ###########################################################################################################
 
 - name: Wait 60 seconds for static routes to be created
-  pause:
+  ansible.builtin.pause:
     seconds: 60
 
 - name: Get all static routes

diff --git a/tests/integration/targets/ntnx_user_groups_v2/tasks/user_groups.yml b/tests/integration/targets/ntnx_user_groups_v2/tasks/user_groups.yml
@@ -252,11 +252,11 @@
 #   register: result
 #   ignore_errors: True
 
-# - set_fact:
+# - ansible.builtin.set_fact:
 #     group_type: "{{ result.response | map(attribute='group_type') | list | unique }}"
 
 # - name: Fetch only LDAP user groups Status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.changed == false
@@ -275,11 +275,11 @@
 #   register: result
 #   ignore_errors: True
 
-# - set_fact:
+# - ansible.builtin.set_fact:
 #     group_type: "{{ result.response | map(attribute='group_type') | list | unique }}"
 
 # - name: Fetch only SAML user groups Status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.changed == false

diff --git a/tests/integration/targets/ntnx_users_v2/tasks/users_operations.yml b/tests/integration/targets/ntnx_users_v2/tasks/users_operations.yml
@@ -427,7 +427,7 @@
 #   ignore_errors: true
 
 # - name: Deactivate local user status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.changed == true
@@ -445,7 +445,7 @@
 #   ignore_errors: True
 
 # - name: Fetch user info using user ext_id criteria and check status result
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.changed == false
@@ -465,7 +465,7 @@
 #   ignore_errors: true
 
 # - name: Activate local user status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.changed == true

diff --git a/tests/integration/targets/ntnx_vms_ngt_v2/tasks/vms_ngt.yml b/tests/integration/targets/ntnx_vms_ngt_v2/tasks/vms_ngt.yml
@@ -597,7 +597,7 @@
 #   ignore_errors: true
 
 # - name: Upgrade NGT in VM Status
-#   assert:
+#   ansible.builtin.assert:
 #     that:
 #       - result.response is defined
 #       - result.changed == true

diff --git a/tests/integration/targets/prepare_foundation_env/playbooks/cleanup.yml b/tests/integration/targets/prepare_foundation_env/playbooks/cleanup.yml
@@ -9,4 +9,4 @@
     #   file:
     #     path: "{{ source }}"
     #     state: absent
-    #   ignore_errors: true
+    #   ignore_errors: true
diff --git a/tests/integration/targets/prepare_ndb_env/paybooks/prepare_env.yml b/tests/integration/targets/prepare_ndb_env/paybooks/prepare_env.yml
@@ -18,4 +18,4 @@
         block: |
           ndb_ip:  "{{ lookup('env', 'NDB_HOST') }}"
           ndb_username: "{{ lookup('env', 'NDB_USERNAME') }}"
-          ndb_password: "{{ lookup('env', 'NDB_PASSWORD') }}"
+          ndb_password: "{{ lookup('env', 'NDB_PASSWORD') }}"