Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 release branch for v4 based module support #522

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

bhati-pradeep
Copy link
Collaborator

Added modules for below namespaces using v4:

  1. Clusters
  2. Storage containers
  3. Networking
  4. Flow Networking
  5. IAM
  6. VMM
  7. Volume Groups
  8. Data Protection

bhati-pradeep and others added 5 commits July 7, 2024 14:00
…ository. (#66)

Sync main branch
---------

Co-authored-by: Pradeepsingh Bhati <[email protected]>

---------

Co-authored-by: Gevorg Khachatryan <[email protected]>
Co-authored-by: alaa-bish <[email protected]>
Co-authored-by: Gianluca Salvo <[email protected]>
Co-authored-by: Gianluca Salvo <[email protected]>
Co-authored-by: Nathaniel Roberts <[email protected]>
…rage container and clusters (#67)


---------
Co-authored-by: bhati-pradeep <[email protected]>
Co-authored-by: Gevorg-Khachatryaan <Gevorg1050.1>
Co-authored-by: alaa-bish <[email protected]>
Co-authored-by: GevorgKhachatryan <[email protected]>
Co-authored-by: george-ghawali <[email protected]>
Co-authored-by: abhinavbansal29 <[email protected]>
#106)

* Adding Fix for GPU module with black and isort fixes for other modules

* Adding more fixes

* Fixed sanity in recovery points and 1 minor fix

* Update ntnx_storage_containers_v2.py

---------

Co-authored-by: abhinavbansal29 <[email protected]>
Co-authored-by: Pradeepsingh Bhati <[email protected]>
abhinavbansal29 and others added 3 commits December 9, 2024 17:38
* Fixed ansible lint in tests/integration/targets/ntnx_recovery_points_v2/tasks/recovery_points.yml

* Fix lints for acps

* Minor fix

* Fixed lint in tests/integration/targets/nutanix_vms/tasks/create.yml

* Revert "Merge branch 'task/fix-ansible-lint' of https://github.com/nutanix/nutanix.ansible into task/fix-ansible-lint"

This reverts commit 16101e4, reversing
changes made to 36b52c3.

* Adding lint fix for role mapping

* commenting all variables

* Fixed ansible lint

* Minor fix

* lint fixes

* Fix in plugins/module_utils/v4/base_info_module.py

* Fix unit tests

---------

Co-authored-by: George Ghawali <[email protected]>
Co-authored-by: bhati-pradeep <[email protected]>
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 9, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12242569630

-- prepare env directory tasks missing due to sanity fixes.

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 9, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12243245072

-- vars issue

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 9, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12243342771

-- vars issue

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 9, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12243437136

@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12251739342

@abhinavbansal29
Copy link
Collaborator

abhinavbansal29 commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12252138276

@abhinavbansal29
Copy link
Collaborator

/ok-to-test

@abhinavbansal29
Copy link
Collaborator

abhinavbansal29 commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12252409370

@abhinavbansal29
Copy link
Collaborator

abhinavbansal29 commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12253161586

@abhinavbansal29
Copy link
Collaborator

abhinavbansal29 commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12253228296

@george-ghawali
Copy link
Collaborator

george-ghawali commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12253367313

@george-ghawali
Copy link
Collaborator

george-ghawali commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12258181059

@george-ghawali
Copy link
Collaborator

george-ghawali commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12258260693

@george-ghawali
Copy link
Collaborator

george-ghawali commented Dec 10, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12258311166

@george-ghawali
Copy link
Collaborator

george-ghawali commented Dec 11, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12271916794

All v4 related modules related tests passed here except ntnx_vms_categories_v2 test (flaky)

ntnx_vms_categories_v2 passed locally attaching logs:
ntnx_vms_categories_v2_result_locally.txt

Coverage report: 74%

* Adding integration fixes for V3

* Adding fixes for static routes and service groups

* minor change in test case name and messages
@nutanix nutanix deleted a comment from george-ghawali Dec 12, 2024
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 12, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12303369635

george-ghawali and others added 8 commits December 16, 2024 23:17
* Adding minor fixes for ansible lint checks

* Adding new line at the end of files for ansible lint fixes

* Adding more lint fixes
* Adding fix for multiple modules names in docs

* Adding docs examples&return for network info V2 module

* Minor doc fixes

---------

Co-authored-by: bhati-pradeep <[email protected]>
* Adding docs to some V4 module utils files

* minor ansible lint fix

* Adding minor ansible lint fix
* fixing authors data for new modules

* Fixing copyrights in V4 files
… APIs based SDKs (#548)

* Adding statement in description to clarify that V4 modules uses PC V4 APIs based SDKs

* Black fix
* Removed the modules using deprecated v4 sdks

* Fixed flake8 and added some comments

* removing deprecated modules from runtime.yml file

* Addressed Comments

---------

Co-authored-by: George Ghawali <[email protected]>
@bhati-pradeep
Copy link
Collaborator Author

bhati-pradeep commented Dec 23, 2024

/ok-to-test

Integration test run status is : failure
Converage is : %
Job link https://github.com/nutanix/nutanix.ansible/actions/runs/12468558501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants