NXDRIVE-2967: Upgrade the deprecated datetime adapter..

[gitofanindya]

Summary by Sourcery

Upgrade dependencies and improve datetime handling. Update the macOS release workflow to use a .p12 certificate format. Remove deprecated datetime adapter warnings from tests.

Enhancements:

• Upgrade various dependencies including pycparser, pyobjc-core, pyobjc-frameworks, python-dateutil, requests, send2trash, and watchdog to their latest versions.

CI:

• Modify the macOS release workflow to use a .p12 certificate format for developer ID application.

Documentation:

• Update the changelog to include new changes and upgrades.

Tests:

• Remove deprecated datetime adapter warnings from test configurations.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR updates several dependencies to their latest versions and fixes timezone-related issues in datetime handling. The main changes include upgrading Python packages, addressing security vulnerabilities, and implementing a fix for zero-byte file handling.

Sequence diagram for zero-byte file handling

sequenceDiagram
    participant FoldersDialog
    participant Path
    FoldersDialog->>Path: get_size(file_path)
    Path-->>FoldersDialog: file_size
    alt file_size == 0
        FoldersDialog->>FoldersDialog: Ignore zero-byte file
    else file_size > 0
        FoldersDialog->>FoldersDialog: Add file to paths
    end

Loading

Class diagram for updated datetime handling

classDiagram
    class AutoRetryCursor {
        +adapt_datetime_iso(val)
        +execute(sql: str, parameters: Iterable[Any])
    }
    note for AutoRetryCursor "Updated to handle datetime with timezone awareness using adapt_datetime_iso method"

Loading

File-Level Changes

Change	Details	Files
Updated multiple Python package dependencies to their latest versions	Upgraded cryptography from 42.0.5 to 43.0.1 to address security vulnerabilities Upgraded requests from 2.31.0 to 2.32.3 Upgraded watchdog from 3.0.0 to 5.0.2 Upgraded python-dateutil from 2.8.2 to 2.9.0.post0 Updated various PyObjC frameworks from 10.1 to 10.3.1	tools/deps/requirements.txt docs/changes/5.5.1.md
Modified datetime handling to use explicit timezone information	Added timezone.utc to datetime conversions Implemented datetime adapter for SQLite operations Fixed timestamp conversions in file information retrieval	nxdrive/dao/base.py nxdrive/client/local/base.py
Added zero-byte file handling in the upload process	Added method to get file size Implemented checks to ignore zero-byte files during upload Updated file processing logic to skip zero-byte files	nxdrive/gui/folders_dialog.py
Updated macOS certificate handling for deployment	Changed certificate file extension from .cer to .p12 Updated certificate import command in deployment script	.github/workflows/release.yml tools/osx/deploy_ci_agent.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @gitofanindya - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 5 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue: The datetime parameter conversion logic should be simplified and the original super().execute() call restored

The current implementation with register_adapter could have unintended side effects. Consider moving the datetime conversion to a separate method and maintaining the original execution flow.

[sourcery-ai]

issue (bug_risk): Return type hint is incorrect - method returns an integer not a boolean

[sourcery-ai]

suggestion (performance): Redundant size check - file size is already available from get_tree_list()

Consider using the size value already provided by get_tree_list() instead of calling get_size() again.

Suggested change

	if self.get_size(file_path) == 0:
	if size == 0:

[sourcery-ai]

suggestion: Error handling should use consistent timezone approach

Both the try and except blocks now use timezone-aware timestamps, but the error handling could be more consistent by using a common approach or constant for the fallback time.

Suggested change

	mtime = datetime.fromtimestamp(0, tz=timezone.utc)
	EPOCH = datetime(1970, 1, 1, tzinfo=timezone.utc)
	mtime = EPOCH

[sourcery-ai]

suggestion: Nested ternary operator could be simplified for better readability

Consider using an if/elif/else block to make the logic more explicit and easier to maintain.

            else:
                if is_direct_transfer:
                    meth = self.dao.get_dt_upload
                else:
                    meth = self.dao.get_upload

[codecov]

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.98%. Comparing base (462f0a0) to head (ed3221c).

Files with missing lines	Patch %	Lines
nxdrive/gui/folders_dialog.py	12.50%	7 Missing ⚠️
nxdrive/client/local/base.py	66.66%	1 Missing ⚠️
nxdrive/dao/base.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@                                   Coverage Diff                                    @@
##           wip-NXDRIVE-2929-upgrade-python-from-3.9.5-to-3.12.3    #5445      +/-   ##
========================================================================================
+ Coverage                                                 50.58%   51.98%   +1.40%     
========================================================================================
  Files                                                        96       96              
  Lines                                                     16109    16121      +12     
========================================================================================
+ Hits                                                       8148     8381     +233     
+ Misses                                                     7961     7740     -221     

Flag	Coverage Δ
functional	42.88% <47.05%> (+0.03%)	⬆️
integration	2.00% <0.00%> (-0.01%)	⬇️
unit	40.43% <41.17%> (+1.77%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles