Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: configurable lang attribute for useLocaleHead #3097

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Sep 13, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2712

This adds the addLangAttribute option to the useLocaleHead and $localeHead functions, after this is merged I will explore changing the default parameters for the functions as suggested in #2712 so that the functions do not return an empty object by default.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede added the v9 label Sep 13, 2024
@BobbieGoede BobbieGoede self-assigned this Sep 13, 2024
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BobbieGoede BobbieGoede force-pushed the feat/add-lang-attribute-locale-head-2 branch from 80e7e72 to a236a6d Compare September 13, 2024 15:30
@BobbieGoede BobbieGoede merged commit a3fb89f into nuxt-modules:main Sep 13, 2024
8 checks passed
@BobbieGoede BobbieGoede deleted the feat/add-lang-attribute-locale-head-2 branch September 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to add lang attribute to useLocaleHead composable
2 participants