Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for input and output values that include nuxt aliases #309

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AndriiGera
Copy link

This PR includes a fix for incorrect resolve of input and output configuration values with nuxt aliases.
Correspondent bug reports:
#307
#295

Fixed issue with `input` and `output` config that include nuxt aliases
@volkanakkus
Copy link

Hello, we're also waiting this PR because we have to use srcDir property in nuxt.config.ts, that's why we would be appreciated if you prioritize the PR.

Thanks!

@AndriiGera
Copy link
Author

I've published fork with this PR as a separate package. You can temporarily replace current svg-sprite module with it.
To install: yarn add @gvade/nuxt3-svg-sprite.
Don't forget to change @nuxtjs/svg-sprite to @gvade/nuxt3-svg-sprite in your nuxt confg modules section. The configuration key remains the same as svgSprite.
There was a bug with missing #svg-sprite-icons template if iconsPath option was set to false. This bug is fixed as well.

@volkanakkus
Copy link

@AndriiGera thanks for the package, It's now working great. And also can you add elementClass config to your package, because it's not working right now as you can see in following reports:
#298
#294

Thank you for your afford again, the developers of this module seems like they forget about existence of this module.
They've just leave the development after Nuxt 3 update release.

@AndriiGera
Copy link
Author

@volkanakkus Published a fix to elementClass and spriteClassPrefix options. Updated the ModuleOptions type.
Here are the correspondent issues:
#298
#284
You need to update the @gvade/nuxt3-svg-sprite package via your package manager.

@volkanakkus
Copy link

@AndriiGera so much thanks

@volkanakkus
Copy link

volkanakkus commented Sep 2, 2024

@AndriiGera, hello again, is it possible to update this pr with your fixes for elementClass and spriteClassPrefix options. This pr and your fork only has the commit of input output fix. That would be good if you can update the fix here as well.

Because I think there will be another bug which causes hydration problem, I'll try the fix that.

@volkanakkus Published a fix to elementClass and spriteClassPrefix options. Updated the ModuleOptions type. Here are the correspondent issues: #298 #284 You need to update the @gvade/nuxt3-svg-sprite package via your package manager.

@AndriiGera
Copy link
Author

AndriiGera commented Sep 18, 2024

@AndriiGera, hello again, is it possible to update this pr with your fixes for elementClass and spriteClassPrefix options. This pr and your fork only has the commit of input output fix. That would be good if you can update the fix here as well.

Because I think there will be another bug which causes hydration problem, I'll try the fix that.

@volkanakkus yes, sure. Just updated.

@mad-briller
Copy link

@AndriiGera does your changeset fix the publicPath issue at all? we're hitting a problem where we can't serve the svg spritesheets from our cdn so need to serve from node

@AndriiGera
Copy link
Author

@AndriiGera does your changeset fix the publicPath issue at all? we're hitting a problem where we can't serve the svg spritesheets from our cdn so need to serve from node

@mad-briller I think publicPath issue is not considered among these fixes. I'm not even sure what issue do you mean. Is there a bug report about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants