-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backport layers feature from v3 #746
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
still doesn't happy with the result
I'll close the issue. Despite it was almost ready, the troubles with dev mode and polishing merged entities are too complicated to resolve. I think I agree with the decisions we made in Nuxt office hours: people should upgrade their app first to Nuxt 3, then start playing with layers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#747
β Type of change
π Description
This PR intends to optionally enable config parsing like it does in nuxt 3. It also backports nuxt/nuxt#20329
After PR merge you will be able to separate logic into layers, with components, pages, composables, etc.
Current problems:
[x]
we are unable to retrieve project root which is important for c12 to start looking for configs. Latest approach works with dev/prod without any changes, but requiressolved withrootDir: dirname
to be set atnuxt.config.ts
during the testmodule.parent
(as far as we rely on CJS)Main steps to achieve that:
loadC12Config
function on 2nd loading in dev mode and 1st at other modes.rootDir
, which was overcame withmodule.parent
. This is working because now we have CJS module, but in ESM it became undefined. Also we need to admit thatmodule.parent
is deprecated, but Node 14-16 supports it.π Checklist