refactor: use magicast .includes helper
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr replaces the for loop to check if the modules array contains the module name, with a more performant `Array.includes`. ``` "Array.includes time:" 30 "ms" "Manual loop time:" 326 "ms" "Array.includes time:" 27 "ms" "Manual loop time:" 242 "ms" ``` If the purpose of the for loop is backward compatibility, ignore this pr.
This pr replaces the for loop to check if the modules array contains the module name, with a more performant `Array.includes`. ``` "Array.includes time:" 30 "ms" "Manual loop time:" 326 "ms" "Array.includes time:" 27 "ms" "Manual loop time:" 242 "ms" ``` If the purpose of the for loop is backward compatibility, ignore this pr.
pi0
reviewed
Oct 30, 2023
pi0
changed the title
.includes helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces the for loop to check if the modules array contains the added module, with a more performant
Array.includes.If the purpose of the for loop is backward compatibility, ignore this pr.
🔥💚