-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improves vscode integration, support multiple backends #763
Conversation
…er. Handle tunnel-only case
@@ -144,7 +168,7 @@ export async function setup({ nuxt, options, openInEditorHooks, rpc }: NuxtDevto | |||
icon: 'bxl-visual-studio', | |||
category: 'modules', | |||
requireAuth: true, | |||
view: !installed | |||
view: !installed && !(vsOptions?.mode === 'tunnel') | |||
? { | |||
type: 'launch', | |||
title: 'Install VS Code Server', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if we could provide a page in the docs and change the guide here to mention that there are different options to install. Are you interested in helping that as well? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you mean updating this page in the docs?
When you say guide, which guide are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, exactly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make the ms-code-cli the default? It seems to be the recommended approach from MS, but it's different from the current behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - would be good to publish antfu.vscode-server-controller into open-vsx marketplace so the install step works for code-server (from Coder) - https://open-vsx.org/user-settings/extensions
Awesome, thanks a lot! |
🔗 Fixes
❓ Type of change
📚 Description
Improves support for VS Code integration:
codeServer
) under the vscode options object to select the server type to use:ms-code-server
for the legacy (and existing) code-server cli,coder-code-server
for the open-source Coder code-server andms-code-cli
for the VS Code cli server.