-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improves vscode integration, support multiple backends #763
Merged
+125
β15
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7e712e4
Update vscode.ts
gsxdsm 69d59ca
Update general.ts to add the line & column to the path for opening inβ¦
gsxdsm 344ab2d
Update vscode.ts to work with devcontainers
gsxdsm 3ccad35
Add support for both vscode and code-server. Fix embedded vscode servβ¦
gsxdsm c4afb40
Refine the code server type check, move the setting to an option
gsxdsm 5264386
Add CodeServerOptions type and update vscode integration to use it
gsxdsm d67aa32
Add host option to VSCodeIntegrationOptions and update setup functionβ¦
gsxdsm b42b66a
Update Documentation for new VSCode Server options
gsxdsm 155d7b4
Remove extra arguments in the command to install the code-server exteβ¦
gsxdsm 4adeccf
Merge branch 'main' into pr/gsxdsm/763
antfu 6e4aed9
chore: update
antfu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if we could provide a page in the docs and change the guide here to mention that there are different options to install. Are you interested in helping that as well? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I can do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you mean updating this page in the docs?
When you say guide, which guide are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, exactly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make the ms-code-cli the default? It seems to be the recommended approach from MS, but it's different from the current behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation updated: https://github.com/gsxdsm/devtools/blob/main/docs/content/1.guide/1.features.md#vs-code-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - would be good to publish antfu.vscode-server-controller into open-vsx marketplace so the install step works for code-server (from Coder) - https://open-vsx.org/user-settings/extensions