Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nuxt-toc module #1075

Merged
merged 2 commits into from
Oct 21, 2024
Merged

feat: Add nuxt-toc module #1075

merged 2 commits into from
Oct 21, 2024

Conversation

hanyujie2002
Copy link
Contributor

@hanyujie2002 hanyujie2002 commented Sep 23, 2024

πŸ”— Linked issue

resolves #1076

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Nuxt module for table of contents (TOC) component in Nuxt Content projects.

@atinux
Copy link
Member

atinux commented Oct 18, 2024

Hi @hanyujie2002

Is it required that the nuxt-toc component does data fetching as well? This can slow down the application.

I would suggest that it can get the toc as prop

@hanyujie2002
Copy link
Contributor Author

hanyujie2002 commented Oct 18, 2024

Thanks for your suggestion. I've just implemented the toc prop. In the new version, this component won't fetch TOC info when the toc prop is passed. @atinux

@atinux atinux merged commit 5346488 into nuxt:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Listing Request]: nuxt-toc
2 participants