Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctx.nuxt does not exist when build: false in setup #936

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ctx.nuxt does not exist when build: false in setup #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
febdd36
fix(e2e): e2e "build: false" option
Al-Rozhkov Sep 9, 2024
3a5af65
fix(e2e): prioritize ctx.nuxt
Al-Rozhkov Sep 10, 2024
1165552
Merge remote-tracking branch 'origin/main' into fix-918
danielroe Sep 10, 2024
27b9027
chore: add test
Al-Rozhkov Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions examples/app-vitest/test/build-false.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { fileURLToPath } from 'node:url'
import { resolve } from 'node:path'
import { $fetch, setup } from '@nuxt/test-utils/e2e'
import { describe, expect, it } from 'vitest'
import { loadNuxt, buildNuxt } from '@nuxt/kit'

const rootDir = fileURLToPath(new URL('../', import.meta.url))
const randomId = Math.random().toString(36).slice(2, 8)
const buildDir = resolve(rootDir, '.nuxt', 'test', randomId)
const buildOutput = resolve(buildDir, 'output')
const nuxt = await loadNuxt({
cwd: rootDir,
overrides: {
buildDir,
nitro: {
output: {
dir: buildOutput,
},
},
},
})
await buildNuxt(nuxt)
await setup({
rootDir,
buildDir,
nuxtConfig: {
nitro: {
output: {
dir: buildOutput,
},
},
},
build: false,
})

describe('build: false', () => {
it('runs a test', async () => {
const html = await $fetch('/')
expect(html.slice(0, 15)).toMatchInlineSnapshot(`
"<!DOCTYPE html>"
`)
})
})
3 changes: 2 additions & 1 deletion src/core/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ export async function startServer(options: StartServerOptions = {}) {
throw lastError || new Error('Timeout waiting for dev server!')
}
else {
const outputDir = ctx.nuxt ? ctx.nuxt.options.nitro.output!.dir! : ctx.options.nuxtConfig.nitro!.output!.dir!
ctx.serverProcess = exec(
'node',
[resolve(ctx.nuxt!.options.nitro.output!.dir!, 'server/index.mjs')],
[resolve(outputDir, 'server/index.mjs')],
{
nodeOptions: {
stdio: 'inherit',
Expand Down
Loading