Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: index spanish #1856

Merged
merged 11 commits into from Oct 22, 2021
Merged

feat: index spanish #1856

merged 11 commits into from Oct 22, 2021

Conversation

MrJmpl3
Copy link
Contributor

@MrJmpl3 MrJmpl3 commented Oct 13, 2021

This contribution is for my Hacktoberfest 2021 stats, please I would appreciate a lot if you put the label hacktoberfest-accepted if the PR was accepted

Copy link
Contributor

@owlnai owlnai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I added some notes and quick fixes if you want to review them.

content/es/index.md Outdated Show resolved Hide resolved
content/es/index.md Outdated Show resolved Hide resolved
content/es/index.md Outdated Show resolved Hide resolved
content/es/index.md Outdated Show resolved Hide resolved
@smarroufin smarroufin added spanish translations needs to be translated labels Oct 19, 2021 — with Volta.net
Copy link
Contributor

Hi guys, thanks for the contribution!

Quick comment on your PR, I recommand you to read this guide: #1777
Please do not enable the es language in nuxt.config. A maintainer of the repo will take care of it once we want to make it available.
And you will have to copy all non-translated files from /content/en to /content/es, since we sadly do not have fallback yet. 😬

Also maintainers recently discussed the "translations policy" for this repository.
We will now accept a new language only if we are guaranted to have a Lead Translator, someone that can be flagged as codeowner of /content/es and will actively review PRs.
Do you guys @MrJmpl3, @owlnai, (or @hereje since you also contributed on i18n es file) would like to be part of it?

@MrJmpl3
Copy link
Contributor Author

MrJmpl3 commented Oct 19, 2021

@smarroufin Yes I wish part of that 😁

@netlify
Copy link

netlify bot commented Oct 21, 2021

✔️ Deploy Preview for nuxt ready!

🔨 Explore the source changes: 80f6d69

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt/deploys/6171976868490400084314e4

😎 Browse the preview: https://deploy-preview-1856--nuxt.netlify.app

@MrJmpl3 MrJmpl3 marked this pull request as ready for review October 21, 2021 16:30
@MrJmpl3 MrJmpl3 changed the title feat: spanish feat: index spanish Oct 21, 2021
@MrJmpl3
Copy link
Contributor Author

MrJmpl3 commented Oct 21, 2021

I open the review of this PR, contains:

  • No translated files
  • Index translate (in some parts)

Why I do that?

If I wait to finish my translation can be create a disruptive commit with others PR and with the no translated files can invite to other people to help translate

Copy link
Contributor

@MrJmpl3 This is nice and exactly what needs to be done at this time. There is no choice but to push every file, even not translated ones. Hopefully we will have fallback to EN, and we will be able to remove all the non translated files to better keep track of the progress 🙂
The first PR is the hardest, once merged, just keep translating at your pace 💚
One maintainer will then enable it by setting up the i18n config

@MrJmpl3
Copy link
Contributor Author

MrJmpl3 commented Oct 21, 2021

@smarroufin Thank you, please merge this PR to continue translating and so encourage other people to translate the other pages

Copy link
Contributor

I'll merge it tomorrow 👌

Copy link
Contributor

@smarroufin smarroufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge spanish content 🎉
Again, we will make it available in the future. I couldn't give any date, there are some internal NuxtLabs stuff to discuss/do before we make those new languages available on prod.
Thanks again for your time and work guys 💚

@smarroufin smarroufin merged commit b43a012 into nuxt:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants