-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: index spanish #1856
feat: index spanish #1856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! I added some notes and quick fixes if you want to review them.
Co-authored-by: Unai Mengual <[email protected]>
Co-authored-by: Unai Mengual <[email protected]>
Co-authored-by: Unai Mengual <[email protected]>
Hi guys, thanks for the contribution! Quick comment on your PR, I recommand you to read this guide: #1777 Also maintainers recently discussed the "translations policy" for this repository. |
@smarroufin Yes I wish part of that 😁 |
The es lang will be added with the translation after the full Spanish translation has finished.
✔️ Deploy Preview for nuxt ready! 🔨 Explore the source changes: 80f6d69 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt/deploys/6171976868490400084314e4 😎 Browse the preview: https://deploy-preview-1856--nuxt.netlify.app |
I open the review of this PR, contains:
Why I do that? If I wait to finish my translation can be create a disruptive commit with others PR and with the no translated files can invite to other people to help translate |
@MrJmpl3 This is nice and exactly what needs to be done at this time. There is no choice but to push every file, even not translated ones. Hopefully we will have fallback to EN, and we will be able to remove all the non translated files to better keep track of the progress 🙂 |
@smarroufin Thank you, please merge this PR to continue translating and so encourage other people to translate the other pages |
I'll merge it tomorrow 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge spanish content 🎉
Again, we will make it available in the future. I couldn't give any date, there are some internal NuxtLabs stuff to discuss/do before we make those new languages available on prod.
Thanks again for your time and work guys 💚
This contribution is for my Hacktoberfest 2021 stats, please I would appreciate a lot if you put the label
hacktoberfest-accepted
if the PR was accepted