Periodically flush region managers in the LRU queue #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:improvement
manopapad
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
This is OK, but I would have preferred to see a separate counter on each "dead" RegionManager. Then each RegionManager would be guaranteed to last for N field allocations, whereas now it could get unlucky and be removed right away, because it happened to become empty right before an LRU cache flush was scheduled to be triggered.
I think such a feature would actually remove the need for an LRU mechanism altogether; just place dead RegionManagers in a regular list and tick them all up on each field allocation.
|
@magnatelee What is the status of this PR? |
|
@marcinz this PR was a bit rushed and I'll make a follow-on PR that subsumes this. let's keep this open until that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though PR #392 addresses the inefficiency from collecting inactive region managers too eagerly, it may let those inactive managers stick around until the program finishes. This PR introduces another heuristic that periodically flushes inactive managers kept in the LRU queue.