Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require stable API version for submitting an add-on using stable channel #33

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Oct 11, 2023

Currently add-on authors are able to submit stable add-ons to the 2024.1 API.
However, the 2024.1 API is not stable yet.
If a user attempts to install an add-on that is currently marked as compatible with 2024.1, with the final NVDA 2024.1 release, they will encounter errors.

Add-on authors are encouraged to submit add-ons using the "dev" version to NVDA APIs which are not yet released.

This PR makes it required for an add-on to use dev or beta channels when submitting an add-on to an API version that is still in development, and is yet to be released.

For example:

  • in nvdaAPIVersions.json, 2024.1 will include a flag "experimental": true until RC is reached
  • when submitting an add-on with a "stable" channel to 2024.1, the submission will fail with an error encouraging the submitter to use the beta or dev channel

@seanbudd seanbudd merged commit f71e023 into main Oct 11, 2023
@seanbudd seanbudd deleted the requireStableAPIForStableAddon branch October 11, 2023 22:24
seanbudd added a commit to nvaccess/addon-datastore that referenced this pull request Oct 12, 2023
Relates to nvaccess/addon-datastore-validation#33 nvaccess/nvda#15607

As 2024.1 is in alpha, add-ons using the 2024.1 API should not be marked as stable using the stable channel. This PR marks them as dev.
seanbudd added a commit to nvaccess/nvda that referenced this pull request Oct 12, 2023
Link to issue number:
Relates to nvaccess/addon-datastore-validation#33

Summary of the issue:
Information was lacking on the stability of the add-on API and translation strings at various stages of the release process.
This makes the work required or expected for add-on developers and translators unclear.

Description of user facing changes
Expands release process to include more information for translators and add-on developers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants