Add reviewUrl to the json schema #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to nvaccess/nvda#15576 |
seanbudd
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Thanks @nvdaes - could you open an equivalent PR to update:
https://github.com/nvaccess/addon-datastore/blob/master/docs/submitters/jsonMetadata.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the issue
When add-ons are submitted to the store, comments for add-ons reviews in GitHub discussions are been created, and the corresponding URL is being added to add-on metadata.
Development strategy
The reviewUrl key has been added to the json schema.
Testing performed
Run tox. Unfortunately, I'm not able to use runvalidate on my locale machine
Note: Instructions may need to be updated in the readme, @seanbudd.