-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to view new available add-ons #16681
Comments
This is a useful improvement and I believe a simple one. |
RuturajL wrote:
Perhaps, instead of creating a tab for new add-ons, a new checkbox to show just new add-ons maybe added for the Available add-ons tab. Then, when new add-ons are published, the store dialog focusing the Available add-ons tab with this checkbox selected, could be opened. Maybe an easier solution. |
Another aspect to discuss would be if new add-ons should be cached. I think it would be better. Otherwise, when the store dialog is closed and reopened, the list of new add-ons will be empty until new add-ons are published. |
I see that this has been triaged. I'll try to create a PR for implementation. |
@nvdaes - can you go over your implementation plan first? My understanding is this will require server work for NV access to create a view for new add-ons |
Sean wrote:
I have another plan: for each user, new add-ons will be different: just the difference between cached compatible add-ons and add-ons available. What do you think? |
That will be reset to no add-ons every 6 hours as the cache updates, is this desired? |
No, but we may create an additional permanent cache. |
I'd prefer Sean's proposal, i.e. last update date being the same for all users. This provides much more interesting information, i.e. is an add-on actively being maintained? |
Maybe a good idea. My proposal maybe reached with an add-on if desired. |
@nvdaes - we have no immediate plans to work on this, however I'd only start work if it is clear your proposed implementation is accepted by the community. I think more feedback is needed here on what the implementation should look like |
@seanbudd, I prefer starting to work on my initial plan. The implementation requiring server work maybe discussed separately. I think this server implementation maybe done when it"s clearer how it should be done, for example, to show a fixed number of recent add-ons, or the add-ons published in the las week, for all channels, for example. My plan should be easier to implement, at least theoretically. I"ll start working and we can open a separate issoe for this. |
@nvdaes feel free to create a prototype but be warned that it is possible it may not be accepted if the design is unpopular |
I think that finally I prefer to add a new add-ons tab instead of a checkbox to show just new add-ons in the available add-ons tab, so that the tab title is better perceived. I will create a prototype requesting for feedback on the add-ons mailing list ant to people who maybe interested. |
I've created a prototype in the linked pull request:
|
I have thought that it's also useful to notify about new add-ons when new versionns of not installed add-ons are available. Imo the main goal of this feature is to see descriptions to decide if a new add-on should be installed. But descriptions may also be modified in new versions. |
I see that the needs product decission and needs testing labels are removed, so I'll move forward this issue. |
@nvdaes - the PR had those labels, not this issue. The PR is still needing feedback from the community I think |
OK. For any reason I didn't found the labels in the PR, but I see them now. |
I created an approved PR in nvaccess/addon-datastore-validation#38 adding timestamps when add-ons are submitted to the store. This is not merged since NV Access will wait until other related PRs are ready, as mentioned there.
Also, my intention is that the PR created in NVDA repo, as done with other fields of add-ons metadata, shows the add-on submission time in the details panel, formatted as a date. |
@nvdaes, I suggest, instead of "disabled", you name it "Alphabetic, ascending", or something like that.
IMO, users already have enough enabled/disabled stuff to worry about, without having to be concerned with one that is just a sort alphabetic alternative.
|
Luke wrote:
OK. When I create the PR you can review it more. I haven't started since seems on my local master branch tests aren't passing and I will try to fix it. |
Not sure to have fully understood. But as suggested by @XLTechie, I'd avoid adding new controls to sort the list. Couldn't we in the first place just create a new column in the list with the submission date? The list is already sortable thanks to its headers. If we acknowledge that it's not very user friendly, and waiting for a general way to click list headers, we may add an item in the context menu "Sort by" and one sub-item per header. I'd recommend that it be discussed and implemented in a separate issue/PR though. |
@CyrilleB79 , myidea is not about adding new controls to the list. It's to add a combo box in NVDA's Preferences menu, settings, add-on store, like the show add-on update notifications. I think this should be configurable, added in config.conf. |
I think that this feature shouldn't deppend on the ability to sort items by columns in the store, since the submissionTime is a timestamp, not friendly formatted for users. In contrast, the publication date can be formatted, but sorting items by publication date can produce different results, which may not match timestamp order. |
I'm looking forward to seeing the implementation, but personally at the moment I like the concept. I agree with @nvdaes that this is probably a setting that users will not need to change often.
|
Feel free to comment in the linked PR, now a draft. |
Part of #16681, fixup of PR 17091 Summary of the issue: Add-on submissionTime in json metadata files is in milliseconds, but it needs to be converted to seconds to be transformed in a publicationDate Description of user facing changes None Description of development approach Convert add-on submissionTime to seconds in addonStore/models/addon.py
Is your feature request related to a problem? Please describe.
Users may want to be notified when new add-ons are available from the store.
Describe the solution you'd like
Describe alternatives you've considered
An add-on maybe created to notify about new add-ons, but it maybe better to include this in the core adding a new tab to the store.
Additional context
A bot used on Mastodon, on a Feeds subgroup of the add-ons mailing list and on a spanish mailing list is used by some people to be notified about new add-ons:
The text was updated successfully, but these errors were encountered: