Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert add-on submission time to seconds #17193

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

nvdaes
Copy link
Collaborator

@nvdaes nvdaes commented Sep 19, 2024

Link to issue number:

Part of #16681, fixup of PR 17091

Summary of the issue:

Add-on submissionTime in json metadata files is in milliseconds, but it needs to be converted to seconds to be transformed in a publicationDate

Description of user facing changes

None

Description of development approach

Convert add-on submissionTime to seconds in addonStore/models/addon.py

Testing strategy:

Tested manually: now Windows App Essentials 20240918.0.0 dev is shown properly with its publication date.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd merged commit 39da8bf into nvaccess:master Sep 19, 2024
4 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants