Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Word: The result of Word commands to expand or collapse a heading is now reported #17545

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Dec 17, 2024

Link to issue number:

None
Related to #17499, but independent of it.

Summary of the issue:

In MS Word, control+alt+plus and control+alt+- allow to expand and collapse the content below a heading. NVDA does not report the result of this action.

Description of user facing changes

NVDA now reports the result of the Word commands to expand and collapse headings.

Description of development approach

Use Word object model (if available) as done for many Word gestures, no matter if UIA is enabled or not

Testing strategy:

Tested with and without UIA.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79
Copy link
Collaborator Author

Test OK in French system/Word, remapping the gesture as needed, i.e. mapping alt+shift+6, which collapse a heading. Note: it has been done so, because the dash is on the same key as the 6.

But strangely, setting my Word (Office) and my keyboard layout to English, I cannot collapse a heading with alt+shift+- as documented here. Could someone with a real English Word/system confirm that this shortcut is the one to collapse a heading?

@AppVeyorBot
Copy link

See test results for failed build of commit 7e57e5193e

@wmhn1872265132
Copy link
Contributor

It has been tested in the Chinese version of Word. This function works normally. The Chinese version of Word has the same shortcut keys as the English version.

@wmhn1872265132
Copy link
Contributor

After further testing, I found that there seems to be a problem with this function in the Outline view of Word. Regardless of pressing Alt+Shift+Plus sign (+) or Alt+Shift+Minus sign (-), NVDA prompts Expanded, but the operation has been performed correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants