Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor KeyName and KeyValue #81

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

carlh98
Copy link
Contributor

@carlh98 carlh98 commented Nov 28, 2023

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

refactor KeyName and KeyValue.
not adding ! to refactor since version is bumped by previous PR to feature branch

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

PR Checklist

  • Your conventional commits are aligned with the Impact on version section.
  • Documentation is up to date.
    • Content of README.md is up to date.
    • XML documentation is up to date.
  • The BREAKING_CHANGES.md document is up to date.
    • Create a new Major.0.0 header if you do a Major change and list the breaking changes.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@carlh98 carlh98 force-pushed the dev/cama/RefactorKey branch 2 times, most recently from fc41847 to 89ba961 Compare November 28, 2023 15:00
@carlh98 carlh98 requested a review from a team November 28, 2023 15:01
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
@carlh98 carlh98 force-pushed the dev/cama/RefactorKey branch 2 times, most recently from 1870a7b to 3454721 Compare November 28, 2023 15:11
@carlh98 carlh98 changed the title refactor!: refactor KeyName and KeyValue refactor: refactor KeyName and KeyValue Nov 28, 2023
@carlh98 carlh98 force-pushed the dev/cama/RefactorKey branch from 3454721 to f079c7a Compare November 28, 2023 16:39
@carlh98 carlh98 marked this pull request as ready for review November 28, 2023 16:50
@carlh98 carlh98 merged commit c0b9c68 into feature/net7 Nov 29, 2023
4 checks passed
@carlh98 carlh98 deleted the dev/cama/RefactorKey branch November 29, 2023 15:54
@takla21 takla21 mentioned this pull request Mar 4, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants