Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure this repository is up to nventive standards #31

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Conversation

takla21
Copy link
Contributor

@takla21 takla21 commented Feb 29, 2024

GitHub Issue: #

Proposed Changes

  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

This repository is not up to nventive standards.

What is the new behavior?

I've made the following changes to this repository following nventive standards:

  • The readme has been rewritten.
  • BREAKING_CHANGES.md has been added.
  • main is now the default branch
  • PR template has been changed.
  • Ensure conventional-commits are always followed.

Checklist

Please check if your PR fulfills the following requirements:

  • Documentation has been added/updated
  • Automated Unit / Integration tests for the changes have been added/updated
  • Contains NO breaking changes
  • Updated the Changelog
  • Associated with an issue

Other information

@takla21 takla21 force-pushed the dev/keta/cleanup branch 2 times, most recently from 204d40d to 6fd1099 Compare February 29, 2024 17:24
@takla21 takla21 marked this pull request as ready for review February 29, 2024 17:25
@jeanplevesque jeanplevesque requested a review from a team February 29, 2024 18:32
@takla21 takla21 merged commit f6ffcb7 into main Feb 29, 2024
3 checks passed
@takla21 takla21 deleted the dev/keta/cleanup branch February 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants