Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix to unoThemes issues #1

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Arieldelossantos
Copy link

@Arieldelossantos Arieldelossantos commented Apr 18, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Arieldelossantos Arieldelossantos self-assigned this Apr 18, 2024
@Arieldelossantos Arieldelossantos marked this pull request as ready for review April 18, 2024 17:54
@carlh98 carlh98 requested a review from a team April 18, 2024 17:55
@jeanplevesque
Copy link
Member

The PR template should probably be updated on this canary repo because it doesn't make sense.

@Arieldelossantos
Copy link
Author

should i merge this one and create another PR for the Template fix?? @jeanplevesque

@jeanplevesque
Copy link
Member

should i merge this one and create another PR for the Template fix?? @jeanplevesque

@Arieldelossantos Fix it in this PR so that you can also have a better PR template for this PR.

@Arieldelossantos Arieldelossantos changed the title feat: fix to unoThemes issues fix: fix to unoThemes issues Apr 18, 2024
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fix-canaries-errors branch from 8a1bb17 to 7477592 Compare April 18, 2024 18:16
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fix-canaries-errors branch from 7477592 to 8efdb4f Compare April 18, 2024 20:28
@jeanplevesque
Copy link
Member

These are wrong, no? I'm not sure to understand how you can have both these pipelines in the PR validation?
image

@Arieldelossantos
Copy link
Author

These are wrong, no? I'm not sure to understand how you can have both these pipelines in the PR validation? image

we're investigating why the variable is not restricting this validation, because we have one to check whether is a PR or not :/

@Arieldelossantos Arieldelossantos merged commit 99f5073 into canaries/dev Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants