forked from nventive/UnoApplicationTemplate
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix to unoThemes issues #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlh98
approved these changes
Apr 18, 2024
The PR template should probably be updated on this canary repo because it doesn't make sense. |
Soap-141
approved these changes
Apr 18, 2024
should i merge this one and create another PR for the Template fix?? @jeanplevesque |
rfabre
approved these changes
Apr 18, 2024
@Arieldelossantos Fix it in this PR so that you can also have a better PR template for this PR. |
Arieldelossantos
changed the title
feat: fix to unoThemes issues
fix: fix to unoThemes issues
Apr 18, 2024
Arieldelossantos
force-pushed
the
dev/arde/fix-canaries-errors
branch
from
April 18, 2024 18:16
8a1bb17
to
7477592
Compare
Arieldelossantos
force-pushed
the
dev/arde/fix-canaries-errors
branch
from
April 18, 2024 20:28
7477592
to
8efdb4f
Compare
jeanplevesque
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andTemplateConfig.md
if you made changes to templating.AzurePipelines.md
andAPP_README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):