-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added kill switch #400
Conversation
src/app/ApplicationTemplate.Access/ApiClients/KillSwitch/IKillSwitchRepository.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Access/ApiClients/KillSwitch/IKillSwitchRepository.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Business/KillSwitch/IKillSwitchService.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Business/KillSwitch/KillSwitchService.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Business/KillSwitch/KillSwitchService.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Presentation/Configuration/NavigationCoreConfiguration.cs
Outdated
Show resolved
Hide resolved
...cationTemplate.Presentation/ViewModels/Diagnostics/Navigation/NavigationDebuggerViewModel.cs
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Shared.Views/Content/Diagnostics/NavigationDebuggerView.xaml
Outdated
Show resolved
Hide resolved
src/app/ApplicationTemplate.Shared.Views/Content/KillSwitch/KillSwitchPage.xaml
Outdated
Show resolved
Hide resolved
Wondering if using this pattern would be better? This would make 100% everything worked.
|
c9d0335
to
b8cc5cb
Compare
In which context? |
Sometimes I have to use a "StartWith", because the navigation is already over when I get there, sometimes I need to not have a startWith, otherwise I will still be in the old viewmodel and the navigation has not started yet, this happens when I start the initial navigationflow. But the thing is, Whether I need a startwith or not is all due to the speed at which the navigation starts, which I'm not 100% is completely consistent? But I do know if I used the pattern I proposed earlier, I would 100% get an error if the test was meant to fail, and I the test would 100% work if the test was not meant to fail. |
Like right now, I have a test failing in the ForceUpdatesShould despite not changing anything related to that test, and the test is ok if I add a task.delay So, I think I'm just going to do that. Otherwise, it might just fail randomly sometimes. |
b8cc5cb
to
f097830
Compare
f097830
to
7055a21
Compare
src/app/ApplicationTemplate.Tests.Functional/KillSwitch/KillSwitchShould.cs
Outdated
Show resolved
Hide resolved
7ba0cd5
to
1e0498f
Compare
1e0498f
to
d373982
Compare
src/app/ApplicationTemplate.Business/KillSwitch/KillSwitchService.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing JP's comment I think it looks good! Good job!
d373982
to
2f9fe7a
Compare
2f9fe7a
to
84a9506
Compare
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andTemplateConfig.md
if you made changes to templating.AzurePipelines.md
andAPP_README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):